fix(charts): remove extra hyphen to make helm linter pass #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hyphen at the end of the closing brackets is responsible for chomping all the whitespaces after the brackets. Thus, a previous YAML separator gets into the same line as the `apiVersion` element from the resource enable by the `if` statement. fixes openebs#271 Signed-off-by: cmontemuino <[email protected]>
be810c2
to
119079d
Compare
|
Hi @cmontemuino Thanks for the PR. Since your changes would need a helm chart bump we would cherry-pick your commit to a version bump PR. |
6 tasks
|
Included in #277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Template
deploy/helm/charts/templates/rbac.yamlis makinghelm lintto fail.What this PR does?:
The hyphen at the end of the closing brackets is responsible for chomping all the whitespaces after the brackets.
Thus, a previous YAML separator gets into the same line as the
apiVersionelement from the resource enable by theifstatement.Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>