Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resize): adding resize support for lvm volumes #4

Merged
merged 3 commits into from
Jan 12, 2021
Merged

feat(resize): adding resize support for lvm volumes #4

merged 3 commits into from
Jan 12, 2021

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Dec 31, 2020 •
edited
Loading

Signed-off-by: Pawan [email protected]

fixes: #3

What this PR does?:

adding resize support for lvm volumes

Checklist:

@pawanpraka1 pawanpraka1 added this to the v0.1 milestone Dec 31, 2020
@akhilerm
Copy link
Member

@pawanpraka1 , Does resize means we can only extend the volume? Can we reduce the size of the volume?

@pawanpraka1
Copy link
Contributor Author

pawanpraka1 commented Dec 31, 2020 •
edited
Loading

@akhilerm Shrinking of persistent volumes is not supported by k8s. So, yeah, CSI resize means volume extension only.

@codecov-io
Copy link

codecov-io commented Dec 31, 2020 •
edited
Loading

Codecov Report

Merging #4 (4fe3a31) into master (54b7da8) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #4      +/-   ##
=========================================
- Coverage    1.56%   1.42%   -0.14%     
=========================================
  Files          11      11              
  Lines         640     702      +62     
=========================================
  Hits           10      10              
- Misses        630     692      +62
Impacted Files Coverage Δ
pkg/driver/agent.go 0.00% <0.00%> (ø)
pkg/driver/controller.go 1.07% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b7da8...4fe3a31. Read the comment docs.

@pawanpraka1
Copy link
Contributor Author

@praveengt could you take a look at this PR.

akhilerm
akhilerm reviewed Jan 6, 2021
View reviewed changes
deploy/lvm-operator.yaml Outdated Show resolved Hide resolved
@pawanpraka1
review comment
d5bf17d 
Signed-off-by: Pawan <[email protected]>
@pawanpraka1 pawanpraka1 mentioned this pull request Jan 6, 2021
Closed
akhilerm
akhilerm reviewed Jan 6, 2021
View reviewed changes
pkg/driver/controller.go Outdated Show resolved Hide resolved
akhilerm
akhilerm approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@akhilerm akhilerm merged commit 3fe8d61 into openebs:master Jan 12, 2021
@pawanpraka1 pawanpraka1 deleted the resize branch February 18, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilerm akhilerm akhilerm approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

support resize for LVM
3 participants
@pawanpraka1 @akhilerm @codecov-io