fix(thin): use volume group size to create thin pool #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7de80f
to
93c6352
Compare
fef466e
to
42b5e00
Compare
Earlier PV size has been used while thin pool creation, which throws insufficient space error in case if thin volume size greater or equal then the actual volumegroup size. As part of this change we are using the half of volumegroup size to make it lesser while creating thin pool. Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
42b5e00
to
096b53b
Compare
Signed-off-by: prateekpandey14 <[email protected]>
096b53b
to
aab6474
Compare
Signed-off-by: prateekpandey14 <[email protected]>
pawanpraka1
reviewed
May 4, 2021
pawanpraka1
reviewed
May 4, 2021
pawanpraka1
reviewed
May 4, 2021
pawanpraka1
reviewed
May 4, 2021
4f2b600
to
0bfd9f4
Compare
Signed-off-by: prateekpandey14 <[email protected]>
0bfd9f4
to
6da9ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 [email protected]
Pull Request template
Why is this PR required? What issue does it fix?:
Handle the thin pool creation which can not be greater or equal to volumegroup size.
What this PR does?:
Earlier PV size has been used while thin pool creation, which throws insufficient space error in case if thin volume
size greater or equal then the actual volumegroup size.
As part of this change we are using the half of volumegroup size to make it lesser while creating thin pool.
Does this PR require any upgrade changes?:
NO
If the changes in this PR are manually verified, list down the scenarios covered::
Checklist:
<type>(<scope>): <subject>