New commit details page (public beta) feedback #139005
Replies: 355 comments 463 replies
-
|
My first reaction to the new page was: What is happening now!?! My second impression was: why is everything 50% bigger, did I Ctrl+Scroll to zoom by accident? And my third was: where are the diff count squares? Also I just found the first bug: when having text selected and trying to extend that selection with shift, that no longer works. Also I was just searching a bit for a commit message because since it is now completely grey, I kinda missed it. |
Beta Was this translation helpful? Give feedback.
-
|
nice |
Beta Was this translation helpful? Give feedback.
-
|
Not nice. Too seriously broken: |
Beta Was this translation helpful? Give feedback.
-
|
ok now i understand what happening here ^^ thank you to this knowledge again .. i a sure i working it properly to make you know ^^ .. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
fix the mess to mess up the order |
Beta Was this translation helpful? Give feedback.
-
|
I personally dislike the new page's design. |
Beta Was this translation helpful? Give feedback.
-
|
چه چیزروادغام وتقسیم می کنیدکه کنم بادوتافرمو ل. وحساب کتاب خودتون میدونیدچکارکنیدباکاربران |
Beta Was this translation helpful? Give feedback.
-
|
Why is customizability in line spacing important for users like the commenter? |
Beta Was this translation helpful? Give feedback.
-
|
Because line spacing itself is a very important thing. |
Beta Was this translation helpful? Give feedback.
-
|
Would you like suggestions on how to override the line height or font size using browser extensions or custom styles? |
Beta Was this translation helpful? Give feedback.
-
|
No, thanks. I know how. |
Beta Was this translation helpful? Give feedback.
-
|
I cant see now how my files have been changed by size, thats not good |
Beta Was this translation helpful? Give feedback.
-
|
We shipped a fix last night to bring back the diff stat visuals (and also show the +/- numbers). Let us know what you think!
(see the Recent fixes and enhancements ✅ section in the discussion description for this and other recent fixes) |
Beta Was this translation helpful? Give feedback.
-
Thanks for responding to feedback and taking it seriously :) |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
من یکسال وقت وزمان وهزینه اینترانت ندادم که امروزتقسیم بشه ویاباچهارتا فرمول سرکیسه ببندین |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
@generalmimon wrote:
I mostly work alone, and this form factor is good for comments that I wouldn't want in the code itself if they're too messy, but belong to specific lines of code and thus would not go well in the commit message. Think of them like sticky notes on a printout of the code, that I could take to a meeting with other developers, and move onto the whiteboard if helpful. |
Beta Was this translation helpful? Give feedback.
-
Please add this. I've just seen the new UI and had to disable it because reviewing a large file when all comments are hidden was a pain. In the end, I had to go through each one of them to check if I had missed any. |
Beta Was this translation helpful? Give feedback.
-
|
good feedback. |
Beta Was this translation helpful? Give feedback.
-
|
My feedback is, thank you for putting the green "beta" mark with a link to this post explaining. I like the new design, but when it happened, I was in the middle of writing comments on a commit and it was very confusing to me why the design changed. I thought for a little while that the project maintainer was collapsing my comments until I found the link to this page. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for this feedback! This new page will be fully rolled out (in beta) by today, but we have other beta features that will be shipping soon, and we'll make sure to test this flow to ensure nothing breaks (and the experience is not confusing). |
Beta Was this translation helpful? Give feedback.
-
|
That's odd, because my page says "Alpha". I would argue that its live, and there is no way to toggle the page back then you can't really call it a beta. |
Beta Was this translation helpful? Give feedback.
-
|
Were there specific aspects of the new design that disrupted your workflow while commenting on a commit? |
Beta Was this translation helpful? Give feedback.
-
|
The problem (as mentioned by others), isn't the scaling, the scaling is actually the same as before. The issue is the If this is for accessibility purposes, then it should be it's own feature preview or option that the user can toggle. Another issue that's not mentioned yet is that commits with really long descriptions now have a "Show more" button instead of just showing the full description. If I'm clicking on a commit, I probably want to read the description. Please don't make me click multiple times. The text could also be made brighter and easier to read as it was before. See with this example commit: mpv-player/mpv@d2f3b66 |
Beta Was this translation helpful? Give feedback.
-
We rolled out a fix for this 🎉. See "Recent fixes and enhancements ✅" above. |
Beta Was this translation helpful? Give feedback.
-
We also just rolled out a new setting that lets you control line height (see description). |
Beta Was this translation helpful? Give feedback.
-
|
I dislike that the file name and path gets shortened despite there being plenty of horizontal space in the bar. And I can't even hover it to get the full path, I have to hover the "expand" button for the purpose of this screenshot. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. Agree --- there's no reason to truncate the file path when there's plenty of space to show it. I opened an issue. |
Beta Was this translation helpful? Give feedback.
-
|
A fix rolled out for this last night! 🎉 Take a look and let us know if you're still seeing a problem. |
Beta Was this translation helpful? Give feedback.
-
|
Honestly, I liked the old design better. I hope there will be an option to switch between them. |
Beta Was this translation helpful? Give feedback.
-
|
I personally agree with @R0rt1z2, I like that github now finally seems to fit the code view to the full width of the screen (which it previously did not do on 4K displays) but the function call navigation and file navigation sidebars are annoying. I understand the usage of the sidebar navigation but I wish that explicitly dismissing it would keep it hidden and not reopen it when I click, highlight, or navigate in the code. Much like @R0rt1z2, this is mostly personal preference, some of which I fixed with greasemonkey scripts but I still feel the behavior is incorrect. I also agree with the comment box width problem. For a long time, GitHub had used explicit pixel widths for many elements instead of using relative spacing and this made viewing on 4K or higher resolution displays quite annoying. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We're looking into it. |
Beta Was this translation helpful? Give feedback.
-
@R0rt1z2 - we rolled out a fix for indentation issues on some browsers. Can you see if it resolves your issue with viewing this commit? |
Beta Was this translation helpful? Give feedback.
-
@willsmythe It seems to be working fine now. I tried with that commit, and the indentation looks correct. I'm using Firefox on Windows.
|
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
... I can't right click to copy/paste the code? |
Beta Was this translation helpful? Give feedback.
-
Noticed this too; selection should (also) stay. |
Beta Was this translation helpful? Give feedback.
-
How about just not hijacking the native right-click behavior? |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
This public discutions can i commented too? |
Beta Was this translation helpful? Give feedback.
-
|
بنده روببخشیدعذرمیخوام ولی خداوکیلی ازی طرف ازتحتساب بازیهامون کم میشه ازی طرف اینجاتقسبم حذف میشه |
Beta Was this translation helpful? Give feedback.
-
|
The new design seems to struggle with tab indentation in files. For the sake of completeness I'll mention that the below screenshots are using 4-space tabs in my user settings but the effect in the new design is the same with the default of 8. Old: New: |
Beta Was this translation helpful? Give feedback.
-
|
seems like it's just "swallowing" the first tab, and even more because the first letter is cut off
|
Beta Was this translation helpful? Give feedback.
-
|
I saw just the new commit page for the first time today and it's not understandable to me how Github has not stopped the beta rollout when there's such an obvious bug. |
Beta Was this translation helpful? Give feedback.
-
|
What browser/OS are you all on, and do you have any plugins for GitHub installed? |
Beta Was this translation helpful? Give feedback.
-
|
Firefox on Linux (X11). No plugins or CSS modifications for GH. |
Beta Was this translation helpful? Give feedback.
-
|
The default-collapsed commit text seems to utterly miss the point of the commit details page. It's also much harder to read – the previous page used #1f2328 on #f1f8ff, which has an excellent contrast of Lc 98.0, but the new page uses #59636e on #fff which works out to only Lc 80.5, which is well below the preliminary APCA Bronze threshold of Lc 90. In conjunction with the smaller font size (was 13px, now 12px), the commit text is now very difficult for me to read. Duplicating the first line of the commit text (once in the big heading, once in the monospace body) seems a bit odd:
Lastly, the line-height of the code is uncomfortably large, I really hope you don't intend to use this style across the whole website going forwards. |
Beta Was this translation helpful? Give feedback.
-
|
Ugh, thanks for pointing out the contrast change. Haven't we learned that light-gray-text-on-white is an anti-pattern by now? |
Beta Was this translation helpful? Give feedback.
-
|
I agree, the commit message is much harder to read because of the light gray and shouldn't be collapsed. I don't understand why it feels like there's an aim to de-emphasize the commit message, it's often more important than the code itself! |
Beta Was this translation helpful? Give feedback.
-
|
A fix for the text color problem has rolled out. You should also now see the full commit message. 🎉 |
Beta Was this translation helpful? Give feedback.
-
|
Great |
Beta Was this translation helpful? Give feedback.
-
|
When you start writing a comment, the textbox now expands off-screen:
so you have to scroll down again to see the button to submit the comment now. If the comment box were not collapsed by default, this would be solved. The page also doesn't seem to have the standard GitHub footer, which doesn't help. On wide screens (and by "wide" I mean "16:9 1440p"), having to mouse all the way over to the right-hand side to add a comment makes it really hard to see which line you're commenting on (unless you want to open the dialog, check the line number on the right (which says "R" for some reason?), pull your eyes back to the left-hand side to check the line number there, and try again if you aimed wrong):
And the tooltips on the comment widget buttons ("Heading", "Bold", etc.) appear to have been dropped, which sucks. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting. The team is working on a fix. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking on the line number first boxes that line, and makes it easier to aim when going to the opposite side of the diff listing. |
Beta Was this translation helpful? Give feedback.
-
|
Links to diffs for specific ranges no longer work. The page does not correctly focus the view on the range present in the URL (for example, the URL ending with |
Beta Was this translation helpful? Give feedback.
-
|
I am a heavy mobile user and I need to review code on the go... 
There is so much wasted horizontal space and the wrapping makes things even worse. This makes reading code unbearable... I'd almost say impossible. I've been using a userscript before the new design that made a few css adjustments but seeing that this isn't possible anymore makes this even more frustrating. |
Beta Was this translation helpful? Give feedback.
-
|
One solution for this is to just stop wrapping things. It makes stuff so harder to read on width constrained devices. Or at least let the user toggle the wrapping behavior. |
Beta Was this translation helpful? Give feedback.
-
|
Also the spacing/heights of the file header is just way too big. Again, on mobile this is way worse than desktop. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We are exploring adding a user setting, similar to the "wrap lines" setting we have when viewing a file. |
Beta Was this translation helpful? Give feedback.
-
|
Probably you'll have to reconfig your base font-size to more sensible one: Or just need a wardrobe sized screen: |
Beta Was this translation helpful? Give feedback.
-
|
Wi are getting FUKED |
Beta Was this translation helpful? Give feedback.
-
|
Some code can be borderline unreadable on mobile |
Beta Was this translation helpful? Give feedback.
-
|
I'm seeing this kind of output even on the desktop. Would prefer to keep things as they were. |
Beta Was this translation helpful? Give feedback.
-
|
Same, this happens on desktop too. I should be able to scroll to see the whole line. Line wrap is not useful here. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. We are working on a fix for tab/indent behavior, and also exploring adding a user setting to toggle line wrapping. |
Beta Was this translation helpful? Give feedback.
-
|
This should be resolved - are you all still seeing the problem? |
Beta Was this translation helpful? Give feedback.
-
|
fixed <tab/indent> beta 3.0 update status |
Beta Was this translation helpful? Give feedback.
-
|
Public, Private fields waiting! |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Not a fan of the Floating Comments. I would prefer if comments were shown uncollapsed. It's hard to tell on the very right side of the file that a little avatar circle left a comment with important code suggestions. I preferred the old comments you could hide when outdated. |
Beta Was this translation helpful? Give feedback.
-
|
On chrome/ubuntu the comments only load when not logged in. When logged in When not logged in |
Beta Was this translation helpful? Give feedback.
-
|
User agent is Looks like it is a 500 error fetching the comments |
Beta Was this translation helpful? Give feedback.
-
|
Looks like standard Chrome UA. |
Beta Was this translation helpful? Give feedback.
-
|
Test in incognito and also in Edge and Opera on Windows. Chrome (android) browser with different IP also tested, same result, error when logged in but works ok when signed out. |
Beta Was this translation helpful? Give feedback.
-
|
I believe the "deferred_comment_data" link: Do you mean this link would fail with your login cookies, but not otherwise? |
Beta Was this translation helpful? Give feedback.
-
|
Apologies maybe I wasn't clear. When I am logged into github I can't see or reply to any comments using the new commit page. This is because the deferred_comment link returns a 500.
When I log out of github (for example if using incognito), I can see the comments and the deferred_comment link works ok. Obviously I can't reply or post comments when logged out.
|
Beta Was this translation helpful? Give feedback.
-
|
Excelente |
Beta Was this translation helpful? Give feedback.
-
|
Please let us have an option to see an exact timestamp, either on hover or (better for mobile) on click! Humanized time descriptions ("2 weeks ago") are meant to be helpful, and if they replace exact timestamps then users are just being forced to have to clone the repo just to be able to see some timestamps that GitHub already has. |
Beta Was this translation helpful? Give feedback.
-
|
Hover is not useful in many circumstances. It's completely unusable on mobile devices, and if you want to see the dates for all of the commits/files in question, it's also not helpful. If I'm telling people when I committed a change, I don't say "I did it last week", as that doesn't help them know whether the workspace they're working from has the change in question. Humanized, friendly, relative, whatever you call them might be helpful on social media (although they're not for me; I always prefer absolute date and time), but for this kind of site they really aren't IMO. At a minimum, there should be an option to display absolute date/time (and ideally, for me at least, ISO 8601 would be ideal -- even though I'm in the US, I always prefer 24 hour time, and there's one hour per year during the fall transition where the localized time is ambiguous, but I'm fine with UTC). |
Beta Was this translation helpful? Give feedback.
-
|
Many, many people rely on that mnemonics (Underlined letters for ALT+Key keyboard navigation)
Why did you remove it? In fact, please rename/describe it better; The current/last names (& value) are misleading, non-self-explanatory, and users couldn't find it without someone telling them what to look for) Correct naming: Values:
It's not boolean! There are 3 modes! |
Beta Was this translation helpful? Give feedback.
-
|
آقا من نکردم این کار هارو دیروز تمام ایمیل های من حک شده بود من گزارش کردم
ماروسافت دونه دونه ریکاوری کرد برام من اصلا خبر ندارم
در تاریخ یکشنبه ۲۹ دسامبر ۲۰۲۴، ۱۰:۲۲ shula ***@***.***> نوشت:
… "Deprecate and ignore gtk-enable-mnemonics and gtk-auto-mnemonics"
properties"
Many, many people rely on that mnemonics (Underlined letters for ALT+Key
keyboard navigation)
- For example, disabled people (who can't use the mouse)
- Or power users who find mnemonics extremely efficient.
- Underline Mnemonics is an *industry standard*. Why break it?
Why did you remove it?
Why does it bother anyone that some users can enable this feature?
Can we have that back?
In fact, please rename/describe it better; The current/last names (&
value) are misleading, non-self-explanatory, and users couldn't find it
without someone telling them what to look for)
Correct naming:
"Show underline accelerator-key shortcuts (mnemonics) "
Values:
1. show 2. auto 3. hide
It's not boolean! There are 3 modes!
—
Reply to this email directly, view it on GitHub
<#139005 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2LOBC55T4KGBXJLNHJQWHD2H6L3FAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNRYHA4DQOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
Hy, What thats? |
Beta Was this translation helpful? Give feedback.
-
The file |
Beta Was this translation helpful? Give feedback.
-
|
Something I found interesting. |
Beta Was this translation helpful? Give feedback.
-
|
Please consider linking to the source of such quotes; the relative timestamp, adjacent to the username of the comment's author, is a permalink to an anchor of the specific comment. Such anchors are quite helpful in discussions like this one, that have so many replies that multiple pages are not loaded by default. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Dags or hamester inthe walletmy inches tonkeper |
Beta Was this translation helpful? Give feedback.
-
` |
Beta Was this translation helpful? Give feedback.
-
|
Hamester DAGS |
Beta Was this translation helpful? Give feedback.
-
|
` |
Beta Was this translation helpful? Give feedback.
-
|
_ - [ ] A_ |
Beta Was this translation helpful? Give feedback.
-
|
Hamester |
Beta Was this translation helpful? Give feedback.
-
A new version of the commit details page is now available in public beta! This new page, which is enabled by default, lets you quickly understand and navigate the changes in a commit with improvements to filtering, commenting, and keyboard navigation!
What's new 🎉
Here are a few of the noteworthy changes:
upanddownkeys on your keyboard. A new context menu also makes it easier to comment, copy, and select.To opt out of the preview, go the Feature Preview dialog on your profile, select New Commit Page, and click Disable.
Let us know what you think!
Investigating 🟨
Things we are discussing and investigating internally (and we welcome your feedback on):
Known issues 🔴
#diff-e727e4R4-R7).) appears before file name in header above diff.gitattributesnot presented as generated)@mention menu does not appear when adding/editing inline commentsIn progress 🧡
(updates coming)
Recent fixes and enhancements ✅
Week of September 16:
Copymenu option not appearing for some users ✅Week of September 23
Screen.Recording.2024-09-26.at.11.34.46.AM.mov
More about compact line height
* Compact line height user setting 🆕: * **What's our plan?** Based on your feedback about the height of diff lines in the new parge, we are adding a user setting under the ⚙️ that you can enable if you want more compact lines. When enabled, the height of diff lines will be `20px` (same as the classic commit details page), otherwise (and by default) they will be `24px`. * **Why a user setting?** It is important that this (and every) page on GitHub is accessible to everyone. [WCAG recommends a minimum of `24x24px` for click targets](https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html) because _some people with physical impairments cannot click small buttons that are close together_. The avatar (which appear when there are comments on a line) and button to add a comment are both important click targets on the line, which is why the default height of the line is 24px. We recognize that some users prefer (and are able to interact with) more compact lines and click targets, which is why we are introducing a user setting.
Beta Was this translation helpful? Give feedback.
All reactions