-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trime can't insert uppercase letters when mode "中文" is enabled #1476
Comments
You can try to reproduce with nightly build: https://github.com/osfans/trime/releases/tag/nightly |
@Bambooin I just tried to reproduce it with nightly build: I downloaded the file Changelog:
Build Info:
I used the same files from my first message in this thread:
---
name: foo
version: 1
sort: original
...
111 i
222 io
333 iou
schema:
schema_id: foo
name: Schema foo
version: 1
engine:
processors:
- ascii_composer
- selector
- key_binder
- speller
- selector
- navigator
- express_editor
segmentors:
- ascii_segmentor
- matcher
- abc_segmentor
- punct_segmentor
- fallback_segmentor
translators:
- echo_translator
- punct_translator
- script_translator
- reverse_lookup_translator
speller:
alphabet: "iou'"
auto_select: false
translator:
dictionary: foo
enable_user_dict: false
key_binder:
import_preset: default
I transferred the files using the command shown below: ssh samsung-galaxy-a02s 'rm -rf /sdcard/rime ; mkdir /sdcard/rime'
rsync -Psavv \
/tmp/default.custom.yaml \
/tmp/rime/foo.dict.yaml \
/tmp/rime/foo.schema.yaml \
samsung-galaxy-a02s:/sdcard/rime After transferring the files, the directory
I launched Trime. I enabled the schemata "Schema foo" and I deployed. After the message "Deploying…" disappeared, I closed Trime. The directory
I opened an application that allowed me to insert text so that the keyboard is shown (I opened the application "Simple Text Editor"). I tried inserting 1-cut.webm |
I thought that copying the files
I am getting the same behavior: I can only insert lowercase letters, I can't insert uppercase letters. See video below. 1-cut.webmChangelog:
Build Info:
|
I think you could try to click the space key or enter key after input |
@tumuyan I tried what you mentioned: I inserted Even if what you mentioned worked, I don't think that would be solution to the problem because, in my opinion, the user should not need to press the space key or the enter key for inserting uppercase letters. Pressing on an uppercase letter should have the same behavior as pressing in a lowercase letter: the letter is inserted in the cursor position. 1-cut.webm2-cut.webm |
I can't reproduce it from last nightly build. I use
|
@Bambooin I could not reproduce this bug in v3.2.19, but I could reproduce it in v3.3.0 and in Nightly Build. I noticed that the file I suspect that v3.3.0 introduced some changes that suppressed the automatic creation of In the paragraphs below, I explain my findings. If you need I provide more information, please let me know. I'm eager to help to solve this bug. In all three experiments, I used these files:
---
name: foo
version: 1
sort: original
...
111 i
222 io
333 iou
schema:
schema_id: foo
name: Schema foo
version: 1
engine:
processors:
- ascii_composer
- selector
- key_binder
- speller
- selector
- navigator
- express_editor
segmentors:
- ascii_segmentor
- abc_segmentor
- punct_segmentor
- fallback_segmentor
translators:
- table_translator
speller:
alphabet: "iou'"
auto_select: false
translator:
dictionary: foo
enable_user_dict: false
key_binder:
import_preset: default
I cloned the rime-prelude repository using the command shown below: cd /tmp/rime \
&& git clone --branch master --depth 1 'https://github.com/rime/rime-prelude' I transferred the files from my desktop computer to my phone using the command shown below: ssh samsung-galaxy-a02s 'rm -rf /sdcard/rime ; mkdir /sdcard/rime'
rsync -Psavv \
/tmp/rime/foo.dict.yaml \
/tmp/rime/foo.schema.yaml \
/tmp/rime/default.custom.yaml \
/tmp/rime/rime-prelude/default.yaml \
/tmp/rime/rime-prelude/key_bindings.yaml \
/tmp/rime/rime-prelude/punctuation.yaml \
/tmp/rime/rime-prelude/symbols.yaml \
samsung-galaxy-a02s:/sdcard/rime Experiment: Use v3.2.19I downloaded du -h ~/Downloads/com.osfans.trime-v3.2.19-0-ge46046ab-armeabi-v7a-release.apk
sha512sum ~/Downloads/com.osfans.trime-v3.2.19-0-ge46046ab-armeabi-v7a-release.apk
The directory in my phone looked like this before deploying: ssh samsung-galaxy-a02s find /sdcard/rime | tree -a --fromfile --noreport
The directory in my phone looked like this after starting Trime for the first time and deploying: ssh samsung-galaxy-a02s find /sdcard/rime | tree -a --fromfile --noreport
The video below shows the behavior when using 1-cut.webmExperiment: Use v3.3.0I downloaded du -h ~/Downloads/com.osfans.trime-v3.3.0-0-g436c8fc4-armeabi-v7a-release.apk
sha512sum ~/Downloads/com.osfans.trime-v3.3.0-0-g436c8fc4-armeabi-v7a-release.apk
The directory in my phone looked like this before deploying: ssh samsung-galaxy-a02s find /sdcard/rime | tree -a --fromfile --noreport
The directory in my phone looked like this after deploying: ssh samsung-galaxy-a02s find /sdcard/rime | tree -a --fromfile --noreport
The video below shows the behavior when using 2-cut.webmExperiment: Use Nightly BuildI downloaded du -h ~/Downloads/com.osfans.trime-nightly-0-gfe9c39dc-armeabi-v7a-release.apk
sha512sum ~/Downloads/com.osfans.trime-nightly-0-gfe9c39dc-armeabi-v7a-release.apk
The directory in my phone looked like this before deploying: ssh samsung-galaxy-a02s find /sdcard/rime | tree -a --fromfile --noreport
The directory in my phone looked like this after deploying: ssh samsung-galaxy-a02s find /sdcard/rime | tree -a --fromfile --noreport
The video below shows the behavior when using 3-cut.webm |
I thought that copying I cloned the rime-prelude and the trime repository using the commannd shown below: rm -rf /tmp/rime \
&& mkdir /tmp/rime \
&& cd /tmp/rime \
&& git clone --branch master --depth 1 'https://github.com/rime/rime-prelude' \
&& git clone --branch develop --depth 1 'https://github.com/osfans/trime' I created the file ---
name: foo
version: 1
sort: original
...
111 i
222 io
333 iou I created the file schema:
schema_id: foo
name: Schema foo
version: 1
engine:
processors:
- ascii_composer
- selector
- key_binder
- speller
- selector
- navigator
- express_editor
segmentors:
- ascii_segmentor
- abc_segmentor
- punct_segmentor
- fallback_segmentor
translators:
- table_translator
speller:
alphabet: "iou'"
auto_select: false
translator:
dictionary: foo
enable_user_dict: false
key_binder:
import_preset: default I created the file
I transferred the files from my desktop computer to my phone using the command shown below: ssh samsung-galaxy-a02s 'rm -rf /sdcard/rime ; mkdir /sdcard/rime'
rsync -Psavv \
/tmp/rime/trime/app/src/main/assets/shared/tongwenfeng.trime.yaml \
/tmp/rime/foo.dict.yaml \
/tmp/rime/foo.schema.yaml \
/tmp/rime/default.custom.yaml \
/tmp/rime/rime-prelude/default.yaml \
/tmp/rime/rime-prelude/key_bindings.yaml \
/tmp/rime/rime-prelude/punctuation.yaml \
/tmp/rime/rime-prelude/symbols.yaml \
samsung-galaxy-a02s:/sdcard/rime The directory
The directory
I tried to insert uppercase letter with the mode "中文" enabled, but the uppercase letters were not inserted. |
I also found the same issue when using nightly and v3.3.0 with this modified tongwenfeng.trime.yaml. |
I cannot find |
This issue could be solved by downgrading to v3.2.19. |
This issue may be fixed in the latest nightly version. In early this morning I pushed a fix that may workaround this. |
摘要 / Summary
I'm not a native Chinese speaker and my Chinese level is not high enough to fully write this bug report in Chinese, so I'm writing it in English.
I'm trying to create a custom
*.dict.yaml
and a*.schema.yaml
file. For the sake of simplicity, I have been able to reproduce the bug using a minimal*.dict.yaml
file and a*.schema.yaml
file. See section "Steps to Reproduce" below.重现步骤 / Steps to Reproduce
I saved the contents of the code block below to
/tmp/rime/foo.dict.yaml
.I saved the contents of the code block below to
/tmp/rime/foo.schema.yaml
.I transferred the files mentioned above using the command shown below:
ssh samsung-galaxy-a02s 'rm -rf /sdcard/rime ; mkdir /sdcard/rime' rsync -Psavv \ /tmp/default.custom.yaml \ /tmp/rime/foo.dict.yaml \ /tmp/rime/foo.schema.yaml \ samsung-galaxy-a02s:/sdcard/rime
After copying the files, the directory
/sdcard/rime
looked like this:I opened Trime and I deployed. After the message "Deploying…" disappeared, I closed Trime. The directory
/sdcard/rime
looked like this:I opened an application that allowed me to insert text so that the keyboard is shown. When the keyboard was shown, the schema "Schema foo" was enabled, I could insert lowercase letters (see video below.) This is expected behavior.
1-cut.webm
I could not insert uppercase letters when the mode "中文" is enabled (see video below.) This is unexpected behavior.
2-cut.webm
I could insert uppercase letters when the mode "西文" is enabled (see video below.) This is expected behavior.
3-cut.webm
预期行为 / Expected Behavior
Pressing on a uppercase letter should insert it when the mode 中文 is enabled.
I have two questions:
Why I can't type uppercase letters when using "Schema foo" and "中文" (i.e. without having to switch to "西文")?
How to type uppercase letters when using "Schema foo" and "中文" (i.e. without having to switch to "西文")?
日志 / Log
No response
截图 / Screenshot
No response
附加信息 / Additional Context
No response
系统版本 / OS Version
Android version 12
应用版本 / App Version
v3.3.0-0-g436c8fc4-release
构建信息 / Build Information
Builder: Release CI
Git Repo: https://github.com/osfans/trime
Build Git Hash: 436c8fc
Build Time: Sep 1, 2024 10:07:17 AM
The text was updated successfully, but these errors were encountered: