-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverse api for nominatim not working #341
Comments
Any updates on this? According to the Nominatin API, 18 must be set in the zoom parameter to get building-level accuracy. However, the code uses a logarithmic operation and 18 becomes -4 in the actual request. |
Please see the demo for the intended use of zoom/scale: leaflet-control-geocoder/demo/index.html Lines 62 to 79 in 0ace940
This behaviour has been around forever, more specifically since 2014, 9a0e966. |
This issue could be easily solved by setting the scale parameter as optional. Something like this: reverse(location: L.LatLngLiteral, scale: number, cb: GeocodingCallback, context?: any) {
const params = reverseParams(this.options, {
lat: location.lat,
lon: location.lng,
zoom: scale < 0 ? undefined : Math.round(Math.log(scale / 256) / Math.log(2)),
addressdetails: 1,
format: 'json'
}); See this |
by default -4 is going in api call for reverse.
in code why log is used to calculate scale
The text was updated successfully, but these errors were encountered: