Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption usage leaks password equality #95

Open
ott opened this issue Mar 25, 2013 · 1 comment
Open

Encryption usage leaks password equality #95

ott opened this issue Mar 25, 2013 · 1 comment

Comments

@ott
Copy link

ott commented Mar 25, 2013

The IV of every encrypted JSON field is the nonce of the request and thus breaks semantic security, i.e. turning the encryption scheme into ECB mode for a particular message. This allows an attack to find out which passwords are the equal if intercepting a get-all-logins response.

The solution is to use a unique random IV per field or encrypting the message a whole or at least the concatenation of the fields.

I can provide a patch if backwards-compatibility can be broken.

@pfn
Copy link
Owner

pfn commented Mar 25, 2013

Indeed, that is true, and a mistake, backward compatibility may be broken,
but all versions must be updated at once. There is also a third party,
kypass companion, that I would like to coordinate with as well. Fortunately
though, the get all passwords request is somewhat rare (only when listing
all passwords in Firefox)

Sent from my tablet
On Mar 25, 2013 10:00 AM, "Matthias-Christian Ott" [email protected]
wrote:

The IV of every encrypted JSON field is the nonce of the request and thus
breaks semantic security, i.e. turning the encryption scheme into ECB mode
for a particular message. This allows an attack to find out which passwords
are the equal if intercepting a get-all-logins response.

The solution is to use a unique random IV per field or encrypting the
message a whole or at least the concatenation of the fields.

I can provide a patch if backwards-compatibility can be broken.


Reply to this email directly or view it on GitHubhttps://github.com//issues/95
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants