New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output for syncer binary location is incorrect #4137

Open

driskell opened this issue Sep 17, 2024 · 1 comment · May be fixed by #4274

Labels

driskell commented Sep 17, 2024

https://github.com/philips-labs/terraform-aws-github-runner/blob/v5.10.4/outputs.tf#L28

It appears to have a variable that doesn't exist but it is also a literal not a variable. I think it is meaning:

location         = "s3://${module.runner_binaries[0].bucket.id}/${module.runner_binaries[0].runner_distribution_object_key}"

The text was updated successfully, but these errors were encountered:

Member

npalm commented Oct 2, 2024

Would you have time to make a fix?

stuartp44 added bug support labels

winwinashwin added a commit to winwinashwin/terraform-aws-github-runner that referenced this issue


          fix: Incorrect syncer binary location in tf outputs (philips-labs#4137)

f3bc972

The output location for syncer binary was not declared correctly in tf
outputs.

Fixes: philips-labs#4137

winwinashwin linked a pull request

that will close this issue

fix: Incorrect syncer binary location in tf outputs #4274

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment