Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPPER_WALLS or LOWER_WALLS and PBCs #658

Open
GiovanniBussi opened this issue Dec 9, 2020 · 2 comments
Open

UPPER_WALLS or LOWER_WALLS and PBCs #658

GiovanniBussi opened this issue Dec 9, 2020 · 2 comments

Comments

@GiovanniBussi
Copy link
Member

It looks like applying PBCs on the difference between the current CV value and that of the wall might not be the correct thing to do. See this post for a practical example.

Should we just replace:

const double cv=difference(i,at[i],getArgument(i));

with

const double cv=getArgument(i)-at[i];

?

I am not totally sure this is the right thing to do. Maybe adding a NOPBC flag to UPPER_WALLS and LOWER_WALLS to disable PBC?

@carlocamilloni
Copy link
Member

I think that the point is that a single upper/lower wall on a periodic CV is meaningless, anyway for u/l walls possible the correct thing is to calculate the distance as cv=getArgument(i)-at[I]; but also throw an error if the CV is periodic (in case suggesting to remove the periodicity using COMBINE)

@Clownshift
Copy link

Hi Devs,
I am trying to use the upper and lower walls bias modules. I wonder if there is any news about this potential issue...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants