-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for newer pip and CUDA computation versions #151
Conversation
85a428a
to
e9d2802
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
- Coverage 78.9% 78.5% -0.4%
=======================================
Files 6 5 -1
Lines 384 378 -6
=======================================
- Hits 303 297 -6
Misses 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Latest torch nightly as of creating this commit is https://github.com/pytorch/pytorch/blob/f84e533a2cb89a42c021dce7d22af7d5bd5f5ac1/setup.py#L235 which requires Python 3.9+. Current latest stable version of torch (2.5.1) still supports Python 3.8. See https://github.com/pytorch/pytorch/blob/v2.5.1/setup.py#L217.
8e19baa
to
228ae8d
Compare
Python 3.7 went end-of-life on June 27th 2023. See https://endoflife.date/python. There is not a Python 3.7 for arm64 using the macos-latest runner for light-the-torch tests.yml workflow.
4132597
to
642a793
Compare
772a824
to
9b38b69
Compare
@pmeier Thanks for your original work in creating |
@jamesobutler Thanks a ton for the PR! I'll find some time this week (I promise!) to merge this and push a release. To give some context: I'm no longer a PyTorch dev / power user and thus have very little use for Since you basically did all the maintainer work in this PR, would you like to have maintainer rights on this repository so that you can push fixes yourself in the future? |
I appreciate your help on this!
Yes, that would be great!
I can discuss with the other Slicer main developers (e.g. @lassoan, also a |
I'm not exactly sure why, that hit hard reading it the first time. I didn't like it at all. But the longer I thought about it, the more sense it makes to me. I wanted to have this PR finished by no later than Thursday and here I am sitting on a Saturday night, because I simply didn't find any time earlier. Coupled with the fact that I'm no longer a user of this project, it makes little sense to keep me as maintainer and by proxy to keep this as my repository. So, yes, I'm happy to transfer it anywhere of your choosing. I'd prefer under the Slicer umbrella to make this a proper community project, but I'm ok with either. Could you open an issue to discuss the details rather than doing it on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments. Can merge on short notice after fix. I'll push v0.8.0 afterwards. Thanks a ton James!
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v2...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
light-the-torch specifies support for python 3.11 in pyproject.toml so lets run unit tests on it as well.
Closes pmeier#146 Closes pmeier#147 Closes pmeier#148
This change should have been included when importlib.metadata import was changed during recent commit that dropped Python 3.7 support. This change was automatically applied by running: python -m pre_commit run --all-files
This should have been completed in the recent commit that dropped Python 3.7 support.
This was automatically applied by running: python -m pre_commit autoupdate Additional dependencies such as black and usort were updated manually. mirrors-prettier was manually set back down to v3.1.0 instead of v4.0.0-alpha.8 to continue using a tag representing a stable version.
This change was automatically applied by running: python -m pre_commit run --all-files
This supports triggering a workflow based on any individual commit or branch. This provides flexibility when testing a wide array of commits See https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch
Python 3.8 went end-of-life on October 7th 2024. See https://endoflife.date/python. Latest Pytorch 2.5 specified support for Python 3.8 in its setup.py, but no Python 3.8 whl files were created. Torch developers resolved their mistake clarifying Python 3.8 support had indeed been dropped. See pytorch/pytorch@5c49db9.
9b38b69
to
1ce6097
Compare
@pmeier Thanks for running through the release process and creating https://github.com/pmeier/light-the-torch/releases/tag/v0.8.0 and https://pypi.org/project/light-the-torch/0.8.0/. |
Pip 23.3.x support
Closes #146
Closes #147
Closes #148
Pip 24.0.x support
Closes #149
This PR includes some general maintenance updates for the github actions workflow to ultimately test the newer pip version. A dependabot workflow has been added so that github actions can be automatically updated and PRs issued. Turn on dependabot alerts at https://github.com/pmeier/light-the-torch/settings/security_analysis.
Python versions have been updated to drop Python 3.7 and 3.8, but to specifically support Python 3.12. This goes along with supporting newer CUDA 12.x computational platforms.