Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip latest workflow #82

Merged
merged 1 commit into from
May 20, 2022
Merged

fix pip latest workflow #82

merged 1 commit into from
May 20, 2022

Conversation

pmeier
Copy link
Owner

@pmeier pmeier commented May 20, 2022

Closes #81, which is a false positive. pip==22.1 was enabled in #80.

This PR does two things:

  1. Instead of relying on success() and failure(), we now rely on steps.tests.outcome. The former also triggered if the unit tests were skipped and thus no issue needed to be created.
  2. The templates were missing two environment variables and so the link was malformed.

@pmeier pmeier merged commit e606268 into main May 20, 2022
@pmeier pmeier deleted the fix-pip-latest branch May 20, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include pip==22.1 in the supported versions
1 participant