Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low-resolution background Image on all Topics links in footer. #11063

Open
akanbifatimah opened this issue Apr 17, 2022 · 5 comments
Open

Low-resolution background Image on all Topics links in footer. #11063

akanbifatimah opened this issue Apr 17, 2022 · 5 comments
Labels
feature explains that the issue is to add a new feature

Comments

@akanbifatimah
Copy link
Contributor

The footer links in the Topics session of https://publiclab.org/wiki/infragram#cameras page all have a low-resolution background Image.
Please describe the desired behavior.
Background-images with high-resolutions.
Additional context (optional)
Feel free to include any applicable: code, screenshots, or gifs.
image
blur footer image

@akanbifatimah akanbifatimah added the feature explains that the issue is to add a new feature label Apr 17, 2022
@ebarry
Copy link
Member

ebarry commented Apr 25, 2022

Thanks for reporting this!
This is not a code-related issue, it's a content issue that does not need programming to solve.
Thank you for highlighting these opportunities to improve, i'll share it with the curation team. Perhaps We might close this issue?

@ebarry
Copy link
Member

ebarry commented Apr 25, 2022

Wow - i have to update my own comment here after teammembers did try to update the photo to be higher res, and the issue IS somewhere in the code. Here's what @bhamster07 wrote in Slack:

Just tested this out with /waste and realized that on all tag pages, the background image pulled from the wiki appears low res. Even when the original image is hi-res: https://publiclab.org/tag/waste, original image: https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/046/522/original/Garbage_barge.jpeg

@ebarry
Copy link
Member

ebarry commented Jun 13, 2022

Still interested in this one!

@TildaDares
Copy link
Member

I think all we need to do here is pass (:original) to the path method on this line:

<section class="tag-header fdb-block pb-0" style="<% if @wiki && @wiki.main_image %>background-image: url(<%= @wiki.main_image.path %>);<% else %>background: #eee;<% end %>" data-block-type="contents" data-id="1">

@jywarren Does the infragram uploads issue in #10210 apply to the tag pages too? If it does we'd also have to add this conditional:
@wiki.main_image.path(main_image.photo_file_name == "blob" ? :original : :large)

@NPDebs
Copy link

NPDebs commented Oct 9, 2022

I think all we need to do here is pass (:original) to the path method on this line:

<section class="tag-header fdb-block pb-0" style="<% if @wiki && @wiki.main_image %>background-image: url(<%= @wiki.main_image.path %>);<% else %>background: #eee;<% end %>" data-block-type="contents" data-id="1">

@jywarren Does the infragram uploads issue in #10210 apply to the tag pages too? If it does we'd also have to add this conditional:
@wiki.main_image.path(main_image.photo_file_name == "blob" ? :original : :large)

Hi. Do you still need help with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature explains that the issue is to add a new feature
Projects
None yet
Development

No branches or pull requests

4 participants