-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Turbolinks for faster loading #2064
Comments
@jywarren I have added this gem and tried on my local instance the speed has increased more than i was thinking. Loading very fast. Whole page is not loading only the things that are changed on the other pages are loading. |
Wow! Are there any drawbacks to this? Any surprises or issues we should
look out for?
…On Mon, Jan 22, 2018 at 1:42 PM, Naman Gupta ***@***.***> wrote:
Just look at the loader on the top of both.
Before applying turbolinks :
[image: without]
<https://user-images.githubusercontent.com/20709985/35237903-e951ee98-ffd1-11e7-9c3b-fe12a0559d21.gif>
After:
[image: with]
<https://user-images.githubusercontent.com/20709985/35237924-f7acdfd4-ffd1-11e7-8ac3-a36289544eac.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2064 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJyO0cU68YnOmNoSa7jowDZMY0r0Vks5tNNadgaJpZM4RoYuY>
.
|
@jywarren I guess we don't have to look for any issue currently but if there can be issues regaring this in future we can sort it out because turbolinks by-default come with rails 4 --onwards and since we have upgraded this project from rails 3 to rails 4 thats why we donot have turbolinks by default becuase there were no turbolinks in rails 3 |
Infact Turbolinks uses Pjax which uses Ajax which only loads the body that is changed by making Ajax Calls. It makes the app behave like single page application even the app is not single page application and evantually it also makes it faster as single page applications are and undoubtly, it also create better user experience. |
Github also uses turbolinks thats why we donot see any loader i guess. |
Wow, cool! Let's test it out on our unstable container. Let me try that out now. unstable.publiclab.org -- it'll take a few minutes to build. |
OK, in stable, we're seeing the typeahead search system not running normally when in a turbolinks page, and found some more JavaScript event changes to make, which i did in #2132. But that seems to have broken some other events. I think this needs more work, and we'll leave all this code in but disable it in production (#2133) for now. Don't be discouraged! There are lots of things we can do to test this out progressively, and let's start by listing things we saw that weren't completely working. In #2132 we have a great start. |
Please describe the problem (or idea)
We can add turbolinks for faster loading of our web-pages.
Turbolinks can make a Rails app feel faster by using JavaScript to replace the page content when clicking a link.
@jywarren What do you think of this?
The text was updated successfully, but these errors were encountered: