Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#double#hashtags and @username#hashtags for nodes and comments #533

Open
jywarren opened this issue May 10, 2016 · 1 comment
Open

#double#hashtags and @username#hashtags for nodes and comments #533

jywarren opened this issue May 10, 2016 · 1 comment
Labels
enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby

Comments

@jywarren
Copy link
Member

Clicking on a link in the format #hashtag in a research note, wiki, or comment now takes you to https://publiclab.org/tag/hashtag (or corresponding tag name) as of #138.

@mathewlippincott suggested a more advanced syntax:

#double#hashtag would take you to a listing of notes with both tags -- this could be at an address like https://publiclab.org/tags/first+second, or https://publiclab.org/tags/first/second -- run from a tags_controller method called "multiple" maybe?

@username#hashtag would take you to notes of that tag for that user -- this could be at an address like https://publiclab.org/author/name/tag/hashtag -- run from a tags_controller method called "author" maybe?

The controller is here: https://github.com/publiclab/plots2/blob/master/app/controllers/tag_controller.rb

The filtering code in #531 is a good example of how to implement this in display of a) research notes, b) wiki revisions and c) comments.

Extra care must be taken with these as the Regex pattern should take precedence over either @mentions or #hashtags alone.

@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby labels May 10, 2016
@Hassanelashram
Copy link
Member

@jywarren Could you give a scenario where two merged hashtags would be used ?
I get the general idea of displaying results that contained 2 hashtags simultaneously but from where would the users be able to click on those ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

No branches or pull requests

2 participants