Simple editor template #6817
Simple editor template #6817
Conversation
|
Aha cool... Will do. Thanks |
|
Cool! |
|
@jywarren do we want to add another node type for these so that we can have the show page looking like
or any ideas on how to go about this? Thanks |
|
Hi, i think we can try to integrate the "prompt" button for inline maps
as @sagarpreet-chadha created in
#6699, into the display of maps at
the top of wiki pages. That way the same button would appear on pages like
https://publiclab.org/onecranston -- what do you think?
…On Fri, Nov 22, 2019 at 6:13 AM Cess ***@***.***> wrote:
@jywarren <https://github.com/jywarren> do we want to add another node
type for these so that we can have the show page looking like
[image: new_wiki]
<https://user-images.githubusercontent.com/17081074/69421459-1d572e00-0d32-11ea-891d-dcbdd0301324.png>
or any ideas on how to go about this? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6817?email_source=notifications&email_token=AAAF6J75A6GS7R2Y6WXE3WDQU65DFA5CNFSM4JPPUPTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE5KUEI#issuecomment-557492753>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6JYP4JOKU662BNOEAJTQU65DFANCNFSM4JPPUPTA>
.
|
|
Sounds good...This is great. Thanks |
858aefa
to
a38a0a2
Compare
|
seems like my route naming was the prob 🤦♀️ ...moved from |
a0985ed
to
3280662
Compare
config/routes.rb
Outdated
| @@ -308,7 +308,7 @@ | |||
|
|
|||
| get 'post' => 'editor#post', :as => :editor_post | |||
| post 'post' => 'editor#post', :as => :editor_path | |||
| get 'post/simple' => 'editor#simple' | |||
| get '/simple_post' => 'editor#simple' | |||
There was a problem hiding this comment.
Hmm, what was the problem here? I liked /post/simple -- was it not finding this in the correct precedence order? Would it work if you moved /post/simple above line 309?
There was a problem hiding this comment.
The capybara test was failing on travis with a error undefined route '/post/undefined....` trying to find another fix
There was a problem hiding this comment.
The error is ActionController::RoutingError: ActionController::RoutingError: No route matches [GET] "/post/undefined"
There was a problem hiding this comment.
Weird! Let me see your capybara tests... can you mark what line of tests fails?
| fill_in("username-login", with: "steff1") | ||
| fill_in("password-signup", with: "secretive") | ||
| click_on "Log in" | ||
| visit(simple_editor_path) |
There was a problem hiding this comment.
Aha what if you say visit('/post/simple') here, and don't use the Rails path generator?
There was a problem hiding this comment.
Having the path as post/simple is causing the error...It is also visible on my server locally..I didn't catch this earlier 😥 I think its a rails error... 🤔 maybe because we do not have a post resource...it expects this to be like editor/simple because we have editor controller...maybe
|
Getting there! |
c8b5304
to
d1a5acc
Compare
3ecdd46
to
cac992e
Compare
|
Hi @jywarren, I am still getting a hold of how the inline-maps works...I have realized that if the tag Also on the map type do we want to leave it as is..or have it with bluish color as it was on the mockup..Thanks |
|
Ah, sorry I was ambiguous! the map should appear on the top in the simple editor, not the resulting published page -- so, in the editor template, I think you could move the map module to the very top (make it the first module) and use CSS to style it! Does this make sense? |
|
And as to the map color, let's switch it to the layer type we were using on the front page of MapKnitter, it looks so nice! |
|
Ah you already made it the first module! Let's then do a couple things - let's use CSS to move the "Add a Location" button and let's get rid of the title at the top of the page - let's just use CSS (and esp. Bootstrap styles! https://getbootstrap.com/docs/4.3/components/) to get this editor to look a lot more like the mockups, what do you think? |
|
Sounds great...thanks Jeff |
7a2f2a3
to
2c1a242
Compare
Remove location-button and display map on load
2174214
to
a24f08f
Compare
|
|
|
Code Climate has analyzed commit a24f08f and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add |
Fixes #6866
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!