Used string interpolation in notes_controller #11489

IdayatSanni · 2022-10-15T16:13:01Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

welcome · 2022-10-15T16:13:03Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌

Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io · 2022-10-15T16:13:08Z

app/controllers/notes_controller.rb

codecov · 2022-10-15T16:21:31Z

Codecov Report

Merging #11489 (ec9da4b) into main (9fa50a8) will not change coverage.
The diff coverage is 66.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11489   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4810     4810           
  Misses        962      962

Impacted Files	Coverage Δ
app/controllers/notes_controller.rb	`85.76% <66.66%> (ø)`

IdayatSanni · 2022-10-15T16:21:59Z

@TildaDares hi, I just created this request but it is saying I have some issues. how do I fix it?

app/controllers/notes_controller.rb

TildaDares · 2022-10-15T16:49:26Z

app/controllers/notes_controller.rb

@@ -470,11 +470,13 @@ def new_note
  end

  def new_preview_note
-    Node.new_preview_note(uid: current_user.uid,
+    Node.new_preview_note(
+      uid: current_user.uid,


Suggested change

+ uid: current_user.uid,

uid: current_user.uid,

Same with this.

Hello, am I understanding that the problem here is that I have to delete one space and bring it forward?

@IdayatSanni The issue is that you added the plus sign in the code.

TildaDares

@IdayatSanni There was a missing quotation mark.

TildaDares · 2022-10-15T16:52:01Z

app/controllers/notes_controller.rb

@@ -273,7 +273,7 @@ def update
        if request.xhr?
          render plain: "#{@node.path(format)}?_=#{Time.now.to_i}"
        else
-          redirect_to URI.parse(@node.path(format)).path + '?_=' + Time.now.to_i.to_s
+          redirect_to "#{URI.parse(@node.path(format)).path}?_=#{Time.now.to_i}


Suggested change

redirect_to "#{URI.parse(@node.path(format)).path}?_=#{Time.now.to_i}

redirect_to "#{URI.parse(@node.path(format)).path}?_=#{Time.now.to_i}"

IdayatSanni · 2022-10-15T20:51:32Z

Hello, thank you for the review. I will work on it

IdayatSanni · 2022-10-15T21:13:39Z

Hello @TildaDares I have made corrections but it is still showing issues. What exactly am I doing wrong please?

codeclimate · 2022-10-16T10:26:14Z

app/controllers/notes_controller.rb

-      location: params[:location])
+    Node.new_preview_note(
+    uid: current_user.uid,
+     title: params[:title],


unexpected token tLABEL
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)

codeclimate · 2022-10-16T10:26:14Z

app/controllers/notes_controller.rb

+    Node.new_preview_note(
+    uid: current_user.uid,
+     title: params[:title],
+     body: params[:body],


unexpected token tLABEL
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)

codeclimate · 2022-10-16T10:26:14Z

app/controllers/notes_controller.rb

+    uid: current_user.uid,
+     title: params[:title],
+     body: params[:body],
+     main_image: params[:main_image],


unexpected token tLABEL
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)

codeclimate · 2022-10-16T10:26:14Z

app/controllers/notes_controller.rb

+     title: params[:title],
+     body: params[:body],
+     main_image: params[:main_image],
+     location: params[:location]


unexpected token tLABEL
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)

Co-authored-by: Tilda Udufo <[email protected]>

app/controllers/notes_controller.rb

codeclimate · 2022-10-16T15:47:25Z

Code Climate has analyzed commit ec9da4b and detected 0 issues on this pull request.

View more on Code Climate.

github-actions · 2022-10-16T15:57:20Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8798116355/artifacts/399993614

TildaDares

Amazing work @IdayatSanni. Thank you!!

welcome · 2022-10-16T16:45:54Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

TildaDares · 2022-10-16T16:46:02Z

Congratulations on merging your PR @IdayatSanni 🎉

IdayatSanni · 2022-10-16T20:08:01Z

Thank you @TildaDares! I appreciate the guidance.

Used string interpolation in notes_controller

bd6eca2

codeclimate bot reviewed Oct 15, 2022

View reviewed changes

app/controllers/notes_controller.rb Show resolved Hide resolved

app/controllers/notes_controller.rb Show resolved Hide resolved

TildaDares reviewed Oct 15, 2022

View reviewed changes

app/controllers/notes_controller.rb Outdated Show resolved Hide resolved

TildaDares reviewed Oct 15, 2022

View reviewed changes

TildaDares requested changes Oct 15, 2022

View reviewed changes

IdayatSanni added 2 commits October 15, 2022 21:54

Update notes_controller.rb

2033204

Update notes_controller.rb

9163540

Update notes_controller.rb

250fc4b

codeclimate bot reviewed Oct 16, 2022

View reviewed changes

Update app/controllers/notes_controller.rb

a17cea8

Co-authored-by: Tilda Udufo <[email protected]>

codeclimate bot reviewed Oct 16, 2022

View reviewed changes

app/controllers/notes_controller.rb Show resolved Hide resolved

Update notes_controller.rb

7a52981

codeclimate bot reviewed Oct 16, 2022

View reviewed changes

app/controllers/notes_controller.rb Outdated Show resolved Hide resolved

Update notes_controller.rb

ec9da4b

TildaDares approved these changes Oct 16, 2022

View reviewed changes

TildaDares merged commit a5d2483 into publiclab:main Oct 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Used string interpolation in notes_controller #11489

Used string interpolation in notes_controller #11489

IdayatSanni commented Oct 15, 2022

welcome bot commented Oct 15, 2022

gitpod-io bot commented Oct 15, 2022

codecov bot commented Oct 15, 2022 •

edited

Loading

IdayatSanni commented Oct 15, 2022

TildaDares Oct 15, 2022

TildaDares Oct 16, 2022

IdayatSanni Oct 16, 2022

TildaDares Oct 16, 2022

TildaDares left a comment

TildaDares Oct 15, 2022

IdayatSanni commented Oct 15, 2022

IdayatSanni commented Oct 15, 2022

codeclimate bot Oct 16, 2022

codeclimate bot Oct 16, 2022

codeclimate bot Oct 16, 2022

codeclimate bot Oct 16, 2022

codeclimate bot commented Oct 16, 2022

github-actions bot commented Oct 16, 2022

TildaDares left a comment

welcome bot commented Oct 16, 2022

TildaDares commented Oct 16, 2022

IdayatSanni commented Oct 16, 2022

	redirect_to "#{URI.parse(@node.path(format)).path}?_=#{Time.now.to_i}
	redirect_to "#{URI.parse(@node.path(format)).path}?_=#{Time.now.to_i}"

Used string interpolation in notes_controller #11489

Used string interpolation in notes_controller #11489

Conversation

IdayatSanni commented Oct 15, 2022

welcome bot commented Oct 15, 2022

gitpod-io bot commented Oct 15, 2022

codecov bot commented Oct 15, 2022 • edited Loading

Codecov Report

IdayatSanni commented Oct 15, 2022

TildaDares Oct 15, 2022

Choose a reason for hiding this comment

TildaDares Oct 16, 2022

Choose a reason for hiding this comment

IdayatSanni Oct 16, 2022

Choose a reason for hiding this comment

TildaDares Oct 16, 2022

Choose a reason for hiding this comment

TildaDares left a comment

Choose a reason for hiding this comment

TildaDares Oct 15, 2022

Choose a reason for hiding this comment

IdayatSanni commented Oct 15, 2022

IdayatSanni commented Oct 15, 2022

codeclimate bot Oct 16, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 16, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 16, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 16, 2022

Choose a reason for hiding this comment

codeclimate bot commented Oct 16, 2022

github-actions bot commented Oct 16, 2022

TildaDares left a comment

Choose a reason for hiding this comment

welcome bot commented Oct 16, 2022

TildaDares commented Oct 16, 2022

IdayatSanni commented Oct 16, 2022

codecov bot commented Oct 15, 2022 •

edited

Loading