Update editor_controller.rb #11507

AlphaRomeoMike · 2022-10-18T08:54:24Z

Removed 'and', replaced the logic with double ampersand

Fixes #11502 🎉🍾

Removed 'and', replaced the logic with double ampersand This PR closes publiclab#11502

welcome · 2022-10-18T08:54:26Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌

Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io · 2022-10-18T08:54:31Z

codeclimate · 2022-10-18T08:56:02Z

app/controllers/editor_controller.rb

@@ -35,12 +35,12 @@ def rich
      @main_image = Image.find_by(id: params[:main_image]).path
    end

-    if params[:tags]&.include? "lat:" and params[:tags]&.include? "lon:"
+    if params[:tags]&.include? "lat:" && params[:tags]&.include? "lon:"


unexpected token tSTRING
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)

codecov · 2022-10-18T09:05:21Z

Codecov Report

Merging #11507 (6b0efce) into main (a5d2483) will not change coverage.
The diff coverage is 25.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11507   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4810     4810           
  Misses        962      962

Impacted Files	Coverage Δ
app/controllers/editor_controller.rb	`76.74% <25.00%> (ø)`
app/models/user.rb	`86.23% <0.00%> (-0.27%)`	⬇️
app/controllers/home_controller.rb	`95.58% <0.00%> (-0.07%)`	⬇️
app/controllers/relationships_controller.rb	`71.42% <0.00%> (ø)`
app/controllers/spam2_controller.rb	`72.54% <0.00%> (+0.70%)`	⬆️

IvyJeptoo · 2022-10-19T18:08:53Z

@AlphaRomeoMike can I help you out with the tests?

AlphaRomeoMike · 2022-10-19T18:10:26Z

@AlphaRomeoMike can I help you out with the tests?

Yes please

IvyJeptoo · 2022-10-19T18:20:54Z

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

AlphaRomeoMike · 2022-10-21T06:08:42Z

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

IvyJeptoo · 2022-10-21T08:51:55Z

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

How do you suggest I help you?

AlphaRomeoMike · 2022-10-21T09:31:34Z

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

How do you suggest I help you?

Balaclava_Nerd#6566 on Discord

IvyJeptoo · 2022-10-21T10:20:42Z

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

How do you suggest I help you?

Balaclava_Nerd#6566 on Discord

Great, sent!(Ivy J)

TildaDares

Hi @AlphaRomeoMike, lat: and lon: need to be wrapped in parentheses. The same thing applies to the other lines. Thank you!

app/controllers/editor_controller.rb

Co-authored-by: Tilda Udufo <[email protected]>

app/controllers/editor_controller.rb

codeclimate · 2022-10-25T05:08:43Z

Code Climate has analyzed commit 6b0efce and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	3

View more on Code Climate.

github-actions · 2022-10-25T05:17:51Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8942803689/artifacts/410443645

TildaDares

Amazing work @AlphaRomeoMike. Thank you!

cesswairimu · 2022-10-31T18:39:42Z

Looking great, thanks all, merging now.

@IvyJeptoo @AlphaRomeoMike would any of you like to open an issue and fix the code-climate warnings raised here? you can find the suggestions here https://codeclimate.com/github/publiclab/plots2/pull/11507, Its similar changes @TildaDares mentioned above.

welcome · 2022-10-31T18:40:07Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

Update editor_controller.rb

07ed51d

Removed 'and', replaced the logic with double ampersand This PR closes publiclab#11502

AlphaRomeoMike requested a review from a team as a code owner October 18, 2022 08:54

codeclimate bot reviewed Oct 18, 2022

View reviewed changes

cesswairimu mentioned this pull request Oct 19, 2022

replace "and" with "&&" editor-controller #11502

Closed

5 tasks

TildaDares requested changes Oct 21, 2022

View reviewed changes

app/controllers/editor_controller.rb Outdated Show resolved Hide resolved

Update app/controllers/editor_controller.rb

6b0efce

Co-authored-by: Tilda Udufo <[email protected]>

codeclimate bot reviewed Oct 25, 2022

View reviewed changes

app/controllers/editor_controller.rb Show resolved Hide resolved

app/controllers/editor_controller.rb Show resolved Hide resolved

app/controllers/editor_controller.rb Show resolved Hide resolved

TildaDares approved these changes Oct 25, 2022

View reviewed changes

cesswairimu mentioned this pull request Oct 26, 2022

Update editor_controller.rb #11544

Closed

5 tasks

cesswairimu merged commit 7aadb93 into publiclab:main Oct 31, 2022

cesswairimu mentioned this pull request Oct 31, 2022

replace "and" with "&&" editor-controller #11549

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update editor_controller.rb #11507

Update editor_controller.rb #11507

AlphaRomeoMike commented Oct 18, 2022

welcome bot commented Oct 18, 2022

gitpod-io bot commented Oct 18, 2022

codeclimate bot Oct 18, 2022

codecov bot commented Oct 18, 2022 •

edited

Loading

IvyJeptoo commented Oct 19, 2022

AlphaRomeoMike commented Oct 19, 2022

IvyJeptoo commented Oct 19, 2022

AlphaRomeoMike commented Oct 21, 2022

IvyJeptoo commented Oct 21, 2022

AlphaRomeoMike commented Oct 21, 2022

IvyJeptoo commented Oct 21, 2022

TildaDares left a comment

codeclimate bot commented Oct 25, 2022

github-actions bot commented Oct 25, 2022

TildaDares left a comment

cesswairimu commented Oct 31, 2022

welcome bot commented Oct 31, 2022

Update editor_controller.rb #11507

Update editor_controller.rb #11507

Conversation

AlphaRomeoMike commented Oct 18, 2022

welcome bot commented Oct 18, 2022

gitpod-io bot commented Oct 18, 2022

codeclimate bot Oct 18, 2022

Choose a reason for hiding this comment

codecov bot commented Oct 18, 2022 • edited Loading

Codecov Report

IvyJeptoo commented Oct 19, 2022

AlphaRomeoMike commented Oct 19, 2022

IvyJeptoo commented Oct 19, 2022

AlphaRomeoMike commented Oct 21, 2022

IvyJeptoo commented Oct 21, 2022

AlphaRomeoMike commented Oct 21, 2022

IvyJeptoo commented Oct 21, 2022

TildaDares left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 25, 2022

github-actions bot commented Oct 25, 2022

TildaDares left a comment

Choose a reason for hiding this comment

cesswairimu commented Oct 31, 2022

welcome bot commented Oct 31, 2022

codecov bot commented Oct 18, 2022 •

edited

Loading