Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROOT prompt tab completion "leaks" private members #10535

Open
jblomer opened this issue May 6, 2022 · 3 comments
Open

ROOT prompt tab completion "leaks" private members #10535

jblomer opened this issue May 6, 2022 · 3 comments
Assignees
Labels

Comments

@jblomer
Copy link
Contributor

jblomer commented May 6, 2022

For the following class definition

class A {
public:
   int x; 
};
class B : public A {
private:
   using A::x;
};

the tab completion of b.<tab> of an object B b; shows x. Normally, private data members are not shown though.

@jblomer jblomer added the bug label May 6, 2022
@jblomer jblomer changed the title ROOT prompt tab-completion shows private members ROOT prompt tab completion can show private members May 6, 2022
@jblomer jblomer changed the title ROOT prompt tab completion can show private members ROOT prompt tab completion "leaks" private members May 6, 2022
@jalopezg-git
Copy link
Contributor

RInt tab completion seems to be just using the list of members returned by TClass::GetListOfAllPublicDataMembers(), which for the reproducer above includes x. 😮‍💨

@Axel-Naumann
Copy link
Member

How crucial is the fix of this - is there a problem (beyond tab completion) that is a consequence of this bug? This seems to be a very uncommon setup for member access; unless I get some good motivation I'm going to flag this as "low priority". Let me know!

@dpiparo dpiparo assigned dpiparo and devajithvs and unassigned Axel-Naumann Feb 4, 2024
@dpiparo
Copy link
Member

dpiparo commented Feb 4, 2024

This is low priority, but I add more eyes to it: perhaps we can have a simple idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants