WIP: Add support for NVIDIA nvc++ compiler #17000
Conversation
Test Results 18 files 18 suites 4d 15h 23m 21s ⏱️ Results for commit f41386a. |
There was a problem hiding this comment.
Have you tried to run the test suite for ROOT with this pull request and nvcc? My worry is that we have to execute cuda code in the interpreter through clang and some changes in the interpreter's cmake files seem to go towards getting the nvcc runtime somehow in cling.
| @@ -9,7 +9,14 @@ | |||
| #--------------------------------------------------------------------------------------------------- | |||
|
|
|||
| if(NOT CMAKE_CXX_COMPILER_ID MATCHES "(Apple|)Clang|GNU|Intel|MSVC") | |||
There was a problem hiding this comment.
Don't we need a check here for NVHPC too?
There was a problem hiding this comment.
As far as I understand this condition filters out supported compilers. As NVHPC is only partially supported, it must enter this condition - note the NOT in front.
|
@cgleggett so this means the most recent |
|
what is the recommended way to test a build? I was able to do I/O and read/write root files, but that obviously doesn't cover everything. |
|
If you would like to run the full test suite, you can configure with: and run You can also start without the |
|
building the tests have revealed a few more issues with support for flags in nvc++. WIPing until these are addressed. |
This Pull request:
Adds support for NVIDIA's nvc++ compiler
Fixes #16975
Changes or fixes:
This allows clean compilation on ARM (NVIDIA Grace) CPUs.