Avoid infinite recursion in implicit conversion #17536
Merged
+107
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check `klass == ctxt->fCurScope` in ConvertImplicit was always returning false due to a bad construction of the `ctxt` variable of type `CPyCppyy::CallContext`. In particular, the `fCurScope` of the context is taken as the `fScope` data member of the instance converter. This value is usually created at construction time, for example in the `STLStringViewConverter` constructor, by calling `Cppyy::GetScope`. The `GetScope` implementation of ROOT's clingwrapper was outdated w.r.t. the cppyy-backend implementation. This commit aligns the two implementations, thus fixing issues such as the one reported at root-project#17497.
1 task
Test Results 18 files 18 suites 3d 22h 25m 6s ⏱️ Results for commit 053d1bc. ♻️ This comment has been updated with latest results. |
|
So the failure on Windows is due to |
|
@bellenot thank you for your investigation! I will then disable this test on Windows pending a fix to a much larger issue on the platform. |
1 task
38e81ae to
50515b0
Compare
Disabled on MacOS ARM and Windows because LLVM JIT fails to catch exceptions.
guitargeek
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17497
@guitargeek These changes, taken from https://github.com/wlav/cppyy-backend/blob/master/clingwrapper/src/clingwrapper.cxx , fix the reproducer at the linked issue. Let's see what the rest of the CI says. Then we may want to discuss how to incorporate these changes into the repository.