Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong result of function replace_infinites #12

Closed
Gluttton opened this issue Dec 7, 2013 · 2 comments
Closed

Wrong result of function replace_infinites #12

Gluttton opened this issue Dec 7, 2013 · 2 comments
Assignees
@saebyn

Comments

@Gluttton
Copy link
Contributor

Gluttton commented Dec 7, 2013

Based on tests: MunkresTest.replace_infinites_4x4Case001_Success, MunkresTest.replace_infinites_4x4Case002_Success, MunkresTest.replace_infinites_4x4Case003_Success and MunkresTest.replace_infinites_4x4Case004_Success result of function replace_infinites is wrong.

It is looks like real bug (when determined min it not checked on equality to infinity, so max became infinity).
@ghost ghost assigned saebyn Dec 7, 2013
@saebyn
Copy link
Owner

saebyn commented Dec 7, 2013

Yep, I've already got this fixed. Thank you for letting me know :)

@Gluttton
Copy link
Contributor Author

Gluttton commented Dec 7, 2013

Thank you for letting me know :)

No problem, it's pleasure for me :) !

P.S. I think when you push fixes you will close this issue.

@saebyn saebyn closed this as completed Dec 7, 2013
Gluttton added a commit to Gluttton/munkres-cpp that referenced this issue Sep 10, 2020
@Gluttton
CI: fix gcovr exclude parameters
1e1cc6a 
Code coverage report generated by gcovr contains redundant data (from
the tests and googletest directories), as result the report inaccurate.

Issue: saebyn#12.
Signed-off-by: Gluttton <[email protected]>
Gluttton added a commit to Gluttton/munkres-cpp that referenced this issue Sep 10, 2020
@Gluttton
add tests for adapters
cafe0af 
Add run-time tests for adapters assignment operators and constructors to
improve a coverage metric.

Issue: saebyn#12.
Signed-off-by: Gluttton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saebyn saebyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saebyn @Gluttton