Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Munkres::pair_in_list always return false #13

Open
Gluttton opened this issue Dec 7, 2013 · 2 comments
Open

Method Munkres::pair_in_list always return false #13

Gluttton opened this issue Dec 7, 2013 · 2 comments

Comments

@Gluttton
Copy link
Contributor

Gluttton commented Dec 7, 2013

Method Munkres::pair_in_list always return false.

I have launched tests with option --gtest_repeat=100 and built test coverage report (using lcov). Based report I found that method Munkres::pair_in_list always return false. I have no idea about is this bug or no, but it's looks suspicious. If this method redundant it can be removed, else test case for it must be found.

I have no idea how attach report in issue, so I just attach screenshot.

munkres1
munkres2

@saebyn
Copy link
Owner

saebyn commented Dec 7, 2013

I'm not sure - it's been a long while since I wrote that, and I can't find the references I used when I did. I'm thinking that there are some cases where it happens. I agree that some examples of this finding a position of a star or prime that's already been added to the star/prime sequence in a prior pass (the case where pair_in_list would return true) would be helpful.

@Gluttton
Copy link
Contributor Author

I have checked that if feed to the stage4 matrix which contain loop of STAR and PRIME signs, the function Munkres::pair_in_list will be called. But now is another question how to prove that matrix with loops of STAR and PRIME signs never can be passed into stage4?

Note: matrix with loops of STAR and PRIME signs looks like:
S - P -
- - - -
P - S -
- - - -

Gluttton added a commit to Gluttton/munkres-cpp that referenced this issue Sep 10, 2020
Both base classes have begin/end functions, so when they called via
adapter instance it leads a compiler error. To fix the issue it is
proposed to explicitly specify functions for the derived class.

Test: ensure that OpenCV and Armadillo are installed,
      $ mkdir build
      $ cd build
      $ cmake -DMUNKRESCPP_DEVEL_MODE=ON ..
      $ make tests
Issue: saebyn#13.
Signed-off-by: Gluttton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants