-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Description
In flipt repo, there are 40 test cases where the target patch contains test data that should be in the test patch. The tests will then fail because the test data is missing/incorrect. This seems like an error because the model should not be expected to generate test data to match a test that it doesn't know about.
Ex. instance_flipt-io__flipt-518ec324b66a07fdd95464a5e9ca5fe7681ad8f9:
PATCH:
...
diff --git a/internal/config/testdata/advanced.yml b/internal/config/testdata/advanced.yml
index a07acc6004..4279e19a5c 100644
--- a/internal/config/testdata/advanced.yml
+++ b/internal/config/testdata/advanced.yml
@@ -8,7 +8,7 @@ ui:
cors:
enabled: true
- allowed_origins: "foo.com,bar.com"
+ allowed_origins: "foo.com bar.com baz.com"
cache:
enabled: true
TEST_PATCH:
diff --git a/internal/config/config_test.go b/internal/config/config_test.go
index 8dbe66289f..1903cdfb32 100644
--- a/internal/config/config_test.go
+++ b/internal/config/config_test.go
@@ -368,7 +368,7 @@ func TestLoad(t *testing.T) {
}
cfg.Cors = CorsConfig{
Enabled: true,
- AllowedOrigins: []string{"foo.com", "bar.com"},
+ AllowedOrigins: []string{"foo.com", "bar.com", "baz.com"},
}
cfg.Cache.Enabled = true
cfg.Cache.Backend = CacheMemory
"before_repo_set_cmd": "git reset --hard 0018c5df774444117b107dfe3fe503d4c7126d73\ngit clean -fd \ngit checkout 0018c5df774444117b107dfe3fe503d4c7126d73 \ngit checkout 518ec324b66a07fdd95464a5e9ca5fe7681ad8f9 -- internal/config/config_test.go",
Metadata
Metadata
Assignees
Labels
No labels