-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It breaks LinkedIn search page. #134
Comments
Thanks for the report! I wasn't able to reproduce the issue - I tried searching for a few keywords on LinkedIn, and changed pages a few times, but the search was still responsive. Can you describe what can cause the issue please? |
Thank you, the new information is helpful! I have some good news and some bad news. Firstly, I don't think the problem as it stands is solvable. Like all search highlighters, Mark My Search has to break up text to insert highlighting elements, which is a problem for some sites. Specifically, I discovered that LinkedIn stores some data in regular elements with Luckily Mark My Search has a mode built to solve this problem. If you open the extension options (from about:extensions or the popup > Options), uncheck "Use CLASSIC highlighting" and save, you should find that it works better. However, my testing on LinkedIn surfaced some issues with the experimental highlighter:
However, it doesn't break LinkedIn, and it does work (in that highlighting appears and is internally correct, even if it doesn't always get visually updated). I will get back to you with updates on this, as I would love to make the new "PAINT" highlighter available for regular use! |
Ok thanks! That's nice to know, and thanks for the fast answer! |
When trying to use the extension on a LinkedIn search.. some parts of the search become unresponsive.
The text was updated successfully, but these errors were encountered: