Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move applicable kernels inside Shift Invariant Class #5151

Closed
4 tasks
jonpsy opened this issue Jan 18, 2021 · 3 comments
Closed
4 tasks

Move applicable kernels inside Shift Invariant Class #5151

jonpsy opened this issue Jan 18, 2021 · 3 comments
Labels

Comments

@jonpsy
Copy link
Contributor

jonpsy commented Jan 18, 2021

This issue address a part of my broader aim to add various kernel support inside RFF. The foundation of which is, to have kernels which are Shift Invariant. This repository has several such kernels, however, they don't derive from the SIV class. My aim, through a series of PR, is to refactor such classes and subsequently add their support to RFF.

Here's a tentative list of kernels I plan to refactor

  • Cauchy Kernel
  • Chi2Kernel
  • Circular Kernel
  • More ...

Since the research is new, not all of the aforementioned kernel would be given RFF support.

I also plan to add new kernels, few of them being:

as they have already been implemented along with their spectral density function inside sklearn repo.

This was referenced Jan 19, 2021
@jonpsy
Copy link
Contributor Author

jonpsy commented Jan 26, 2021

@gf712 The repo already has Chi2Kernel, the only difference between AdditiveChi2Kernel and our current implementation is, we take the exponential & divide by width whereas AdditiveChi2 doesn't.

Shogun Chi2Kernel:
image

Sklearn AdditiveChi2Kernel:
k(x, y) = -Sum [(x - y)^2 / (x + y)]

I was thinking we could assimilate AdditiveChi2Kernel inside Chi2Kernel, and user could choose the one the wish to use using some SG parameter. Or would you rather suggest I create a new class?

@stale
Copy link

stale bot commented Jul 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 25, 2021
@stale
Copy link

stale bot commented Aug 1, 2021

This issue is now being closed due to a lack of activity. Feel free to reopen it.

@stale stale bot closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant