Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Loki and LogQL alongside Prometheus #280

Open
proffalken opened this issue Apr 5, 2022 · 3 comments
Open

Support Loki and LogQL alongside Prometheus #280

proffalken opened this issue Apr 5, 2022 · 3 comments
Labels

Comments

@proffalken
Copy link

Hello!

We're ingesting a significant amount of data via logging and it would be great to be able to create SLI's and SLO's based on LogQL syntax for Loki as well as PromQL.

It all seems to work apart from the point at which Sloth tries to validate that the logql is valid promql, at which point it falls apart rapidly!

Is there any way Sloth could try and validate against https://github.com/grafana/loki/blob/main/pkg/logql/syntax/parser.go as well as against the Prom parser?

@slok
Copy link
Owner

slok commented Apr 23, 2022

Hi @proffalken

Sloth's main focus is Prometheus, however, there have been some other requests about this: #255

The problem of start supporting both is that we would need to start maintaining both and as you can see in the other comment, the Kubernetes operator would need tweaks.

I will think about maybe adding an option for the parsing side or adding support for configmap style, or both.

Thanks!

@slok slok added enhancement New feature or request kubernetes Rules labels Apr 23, 2022
@proffalken
Copy link
Author

Thanks @slok - For now we've written something internally in Python that almost replicates Sloth for Loki, but it would be great to not need to maintain it and somehow get similar functionality in Sloth instead!

@jleloup
Copy link

jleloup commented Sep 5, 2023

Would using Loki metrics generator be a suitable solution for this problem ?

My understanding is that SLOs & SLAs are numeric by nature, thus having a first step transforming log events into metrics before computing an SLO feels like a valid approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants