Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate views #1096

Merged
merged 8 commits into from
Dec 30, 2024
Merged

chore: deprecate views #1096

merged 8 commits into from
Dec 30, 2024

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Dec 27, 2024 •
edited
Loading

Description

This PR fixes #1068 #447

Summary

This PR does....

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

@vercel Vercel
Copy link

vercel bot commented Dec 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 8:42pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1096 will not alter performance

Comparing chore/remove-views (3863653) with main (7495342)

Summary

✅ 138 untouched benchmarks
⁉️ 8 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chore/remove-views Change
⁉️ test_get_async_decorator_view 4.7 ms N/A N/A
⁉️ test_get_async_view 4.7 ms N/A N/A
⁉️ test_get_sync_decorator_view 4.7 ms N/A N/A
⁉️ test_get_sync_view 4.7 ms N/A N/A
⁉️ test_post_async_decorator_view 4.8 ms N/A N/A
⁉️ test_post_async_view 4.7 ms N/A N/A
⁉️ test_post_sync_decorator_view 4.8 ms N/A N/A
⁉️ test_post_sync_view 4.7 ms N/A N/A

@sansyrox sansyrox merged commit 8aa97ea into main Dec 30, 2024
62 of 66 checks passed
@sansyrox sansyrox deleted the chore/remove-views branch December 30, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we deprecate Views?
1 participant
@sansyrox