Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvment: Add route set to improve 404 responce time. #405

Closed
wants to merge 1 commit into from
Closed

improvment: Add route set to improve 404 responce time. #405

wants to merge 1 commit into from

Conversation

mikaeelghr
Copy link
Contributor

Description

This PR fixes #222

@netlify
Copy link

netlify bot commented Feb 11, 2023 •
edited
Loading

✅ Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit 2f10509
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/63e7cf4a53ab3500089d9097

@AntoineRR
Copy link
Collaborator

Hi and thank you for taking the time to open this PR! We appreciate your interest and your willingness to contribute 😄
However I took a look at the code and I'm not sure we need this new RouteSet struct. This adds a new step before actually routing on the correct function to execute it, and would just make 404 response faster and everything else slower.
This issue may not be relevant anymore, but let's see if @sansyrox agrees with me?

@mikaeelghr
Copy link
Contributor Author

Thanks for your comment @AntoineRR.

I agree with you and I think this change has increased the complexity and also does not improve performance overall.
So if you agree, we can close the PR.

@sansyrox
Copy link
Member

@mikaeelghr @AntoineRR , I just saw this PR. I agree with @AntoineRR here.

However, we really appreciate the intent here @mikaeelghr 😄

@sansyrox sansyrox closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRR AntoineRR Awaiting requested review from AntoineRR

@sansyrox sansyrox Awaiting requested review from sansyrox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a way to precompute the route existence
3 participants
@mikaeelghr @AntoineRR @sansyrox