Skip to content

feat(lyrics-plus): allow to change display of lyrics translation#3297

Merged
rxri merged 1 commit intospicetify:mainfrom
AndreasLrx:main
Feb 8, 2025
Merged

feat(lyrics-plus): allow to change display of lyrics translation#3297
rxri merged 1 commit intospicetify:mainfrom
AndreasLrx:main

Conversation

@AndreasLrx
Copy link
Copy Markdown
Contributor

This PR adds a new option to the lyrics-plus app to choose the display mode of the lyrics translation:

  • Replace: Actual behavior, replacing the original lyrics with its translation
  • Below: Display the original lyrics, and the translated line below in a lower opacity (as in the screen)

I'm not used to work on JS projects so I still have some small issues about this PR:

  • Translated lines and behavior are repeated for each UnsyncedLyricsPage, SyncedExpandedLyricsPage SyncedLyricsPage and I feel like this could be refactored.
  • I didn't now how to name the new option, because there is already a Display Mode so any suggestion to rename the option is welcomed
  • When changing said option, it doesn't reload the lyrics div. It works when disabling and re-enabling the translation though.

Display below

@AndreasLrx AndreasLrx changed the title feat(lyrics-plus): Allow to change display of lyrics translation feat(lyrics-plus): allow to change display of lyrics translation Feb 6, 2025
@AndreasLrx AndreasLrx force-pushed the main branch 2 times, most recently from 9c9ffbe to 0a258ae Compare February 6, 2025 13:54
@rxri rxri merged commit afd98f4 into spicetify:main Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants