feat(lyrics-plus): allow to change display of lyrics translation#3297
Merged
rxri merged 1 commit intospicetify:mainfrom Feb 8, 2025
Merged
feat(lyrics-plus): allow to change display of lyrics translation#3297rxri merged 1 commit intospicetify:mainfrom
rxri merged 1 commit intospicetify:mainfrom
Conversation
9c9ffbe to
0a258ae
Compare
rxri
approved these changes
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to the lyrics-plus app to choose the display mode of the lyrics translation:
I'm not used to work on JS projects so I still have some small issues about this PR:
UnsyncedLyricsPage,SyncedExpandedLyricsPageSyncedLyricsPageand I feel like this could be refactored.Display Modeso any suggestion to rename the option is welcomed