Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scissors wrongly positioned in HtmlOutput #266

Closed
sprain opened this issue Nov 11, 2024 · 5 comments · Fixed by #267
Closed

Scissors wrongly positioned in HtmlOutput #266

sprain opened this issue Nov 11, 2024 · 5 comments · Fixed by #267
Labels
bug Something isn't working

Comments

@sprain
Copy link
Owner

sprain commented Nov 11, 2024 •
edited
Loading

Scissors positioning in HtmlOutput is not always as expected.

This needs further reproduction and digging into.

Bildschirmfoto_2024-11-11_um_11_05_14
@sprain sprain added the bug Something isn't working label Nov 11, 2024
@kohlerdominik
Copy link
Contributor

Probably should also inform @tafel here, so they can keep their eyes open.

@tafel
Copy link
Contributor

tafel commented Nov 11, 2024

Is this from the raw HTML in the browser, or after transforming it into a PDF? If it's a PDF, what is the translator html>pdf?

@sprain
Copy link
Owner Author

sprain commented Nov 11, 2024

It's in a converted pdf, but already looks wrong in HTML.
I changed position behaviour in my PR and probably overlooked the case when the payment slip will be moved around on the page.

@tafel
Copy link
Contributor

tafel commented Nov 11, 2024

I saw you changed the position to fixed. It's probably what's causing the problem.
Check this video

Capture.video.du.2024-11-11.16-05-59.mp4

Do you remember what was the reason for fixed position?

@sprain
Copy link
Owner Author

sprain commented Nov 11, 2024

Do you remember what was the reason for fixed position?

Yes, the previous positioning actually changed the size of the whole payment slip, making it higher by the size of the scissors.

@tafel tafel mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better styles for scissors in HTML output tafel/php-swiss-qr-bill
3 participants
@sprain @tafel @kohlerdominik