From 9f4cdcd54d44cab5a388ccad90d0c40cdc65fac8 Mon Sep 17 00:00:00 2001 From: AndoniLarz Date: Fri, 7 Jun 2024 16:46:54 +0200 Subject: [PATCH 1/3] [Contributing] Add documentation for rebasing when contributing to the docs --- contributing/documentation/overview.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contributing/documentation/overview.rst b/contributing/documentation/overview.rst index aae2c397dec..8b6662f18b2 100644 --- a/contributing/documentation/overview.rst +++ b/contributing/documentation/overview.rst @@ -136,6 +136,10 @@ even remove any content and do your best to comply with the **Step 6.** **Push** the changes to your forked repository: +Before submitting your PR, you may have to update your branch as described in :doc:`the code contribution guide `. + +Then, you can push your changes: + .. code-block:: terminal $ git push origin improve_install_article From 3a6235741edfd421ca32f9ac2b81dd237f54cfc4 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Fri, 18 Oct 2024 10:14:44 +0200 Subject: [PATCH 2/3] Reword --- contributing/documentation/overview.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/contributing/documentation/overview.rst b/contributing/documentation/overview.rst index 8b6662f18b2..183910e6ac6 100644 --- a/contributing/documentation/overview.rst +++ b/contributing/documentation/overview.rst @@ -136,10 +136,6 @@ even remove any content and do your best to comply with the **Step 6.** **Push** the changes to your forked repository: -Before submitting your PR, you may have to update your branch as described in :doc:`the code contribution guide `. - -Then, you can push your changes: - .. code-block:: terminal $ git push origin improve_install_article @@ -189,6 +185,9 @@ changes and push the new changes: $ git push +It's rare, but you might be asked to rebase your pull request to target another +Symfony branch. Read the :ref:`guide on rebasing pull requests `. + **Step 10.** After your pull request is eventually accepted and merged in the Symfony documentation, you will be included in the `Symfony Documentation Contributors`_ list. Moreover, if you happen to have a `SymfonyConnect`_ From 71091ea228f96b2362ee2fe1a8a35c8c49a757c9 Mon Sep 17 00:00:00 2001 From: "Benjamin D." Date: Thu, 17 Oct 2024 17:07:26 +0200 Subject: [PATCH 3/3] [Messenger] Document issue between LISTEN/NOTIFY and prioritized transports https://github.com/symfony/symfony/issues/58574 PostgreSQL LISTEN/NOTIFY feature should not be used with prioritized transports --- messenger.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/messenger.rst b/messenger.rst index 3f78dbaef6c..a32884aac68 100644 --- a/messenger.rst +++ b/messenger.rst @@ -1605,6 +1605,11 @@ in the table. ``use_notify`` (default: ``true``) Whether to use LISTEN/NOTIFY. + .. note:: + + ``use_notify`` will work incorrectly if you use "Prioritized + Transports". Disable the LISTEN/NOTIFY feature in this case. + ``check_delayed_interval`` (default: ``60000``) The interval to check for delayed messages, in milliseconds. Set to 0 to disable checks.