Add refactor changes by @piki

Co-Authored-By: c-bata <[email protected]>

Author: Patrick Reynolds

filter/README.md

@@ -57,7 +57,7 @@ Optionally supply a pattern of tags to match:
 
 ### deleted_tag
 
-Continue if the event which run on 'delete' is a tag.
+Continue if the event deletes a tag.
 
 ```workflow
 action "tag-filter" {
@@ -91,7 +91,7 @@ Optionally supply a pattern of branches to match:
 
 ### deleted_branch
 
-Continue if the event which run on 'delete' is a branch.
+Continue if the event deletes a branch.
 
 ```workflow
 action "branch-filter" {

filter/bin/deleted_branch

@@ -5,7 +5,7 @@ set -e
 pattern="${1:-*}"
 
 if [ -z "$GITHUB_EVENT_PATH" ]; then
-  echo "\$GITHUB_EVENT_PATH" is not set
+  echo "\$GITHUB_EVENT_PATH is not set"
   exit 1
 fi
 

filter/bin/deleted_ref

@@ -12,10 +12,10 @@ case "$DELETE_EVENT_REF" in
     exit 1
     ;;
   $pattern)
-    echo "matches $pattern"
+    echo "$DELETE_EVENT_REF matches $pattern"
     exit 0
     ;;
   *)
-    echo "does not match $pattern"
+    echo "$DELETED_EVENT_REF does not match $pattern"
     exit 78
 esac

filter/bin/deleted_tag

@@ -5,7 +5,7 @@ set -e
 pattern="${1:-*}"
 
 if [ -z "$GITHUB_EVENT_PATH" ]; then
-  echo "\$GITHUB_EVENT_PATH" is not set
+  echo "\$GITHUB_EVENT_PATH is not set"
   exit 1
 fi
 

filter/test/deleted_branch.bats

@@ -6,7 +6,7 @@ PATH="$PATH:$BATS_TEST_DIRNAME/../bin"
 
 export GITHUB_EVENT_PATH="$BATS_TEST_DIRNAME/fixtures/delete_branch_event.json"
 
-@test "deleted_branch: without a event file" {
+@test "deleted_branch: without an event file" {
   unset GITHUB_EVENT_PATH
   run deleted_branch
   [ "$status" -eq 1 ]
@@ -35,5 +35,5 @@ export GITHUB_EVENT_PATH="$BATS_TEST_DIRNAME/fixtures/delete_branch_event.json"
 @test "deleted_branch: does not match" {
   run deleted_branch release-*
   [ "$status" -eq 78 ]
-  [ "$output" = "does not match release-*" ]
+  [ "$output" = "feature-new-command does not match release-*" ]
 }

filter/test/deleted_tag.bats

@@ -6,7 +6,7 @@ PATH="$PATH:$BATS_TEST_DIRNAME/../bin"
 
 export GITHUB_EVENT_PATH="$BATS_TEST_DIRNAME/fixtures/delete_tag_event.json"
 
-@test "deleted_tag: without a event file" {
+@test "deleted_tag: without an event file" {
   unset GITHUB_EVENT_PATH
   run deleted_tag
   [ "$status" -eq 1 ]
@@ -35,5 +35,5 @@ export GITHUB_EVENT_PATH="$BATS_TEST_DIRNAME/fixtures/delete_tag_event.json"
 @test "deleted_tag: does not match" {
   run deleted_tag release-*
   [ "$status" -eq 78 ]
-  [ "$output" = "does not match release-*" ]
+  [ "$output" = "v1.2.3 does not match release-*" ]
 }