Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success streaks should order by RoundType.rank #89

Closed
timreyn opened this issue Sep 16, 2022 · 0 comments · Fixed by #90
Closed

Success streaks should order by RoundType.rank #89

timreyn opened this issue Sep 16, 2022 · 0 comments · Fixed by #90

Comments

@timreyn
Copy link
Contributor

timreyn commented Sep 16, 2022

The query for "longest success streak" doesn't sort by RoundType.rank (https://github.com/thewca/statistics/blob/6f98049999b6edf1977ad6d9523053c662328cff/misc/python/statistics/longest_success_streak.py). This means that, for competitions with multiple rounds, it's nondeterministic what order they are returned in.

I noticed this for my clock success streak. Last week it was 116 (correct), early this week it dropped to 111, and when AmherstOpen2022 results were added it went back up to 116 (should be 121 now). My last DNF was in round 1 of a 2-round competition, so the finals of that competition appear to be switching back and forth between being included and not.

Thank you!
timreyn added a commit to timreyn/statistics that referenced this issue Sep 18, 2022
@timreyn
Sort by RoundType in success streak.
14e07f9 
Currently the longest_success_streak query does not sort rounds, which leads to nondeterminism when a streak begins / ends during a multi-round competition.

In addition, stop joining with Events because this table is not used in the query.

Fixes thewca#89.
timreyn added a commit to timreyn/statistics that referenced this issue Sep 18, 2022
@timreyn
Sort by RoundType in success streak.
6cf1d11 
Currently the longest_success_streak query does not sort rounds, which leads to nondeterminism when a streak begins / ends during a multi-round competition.

In addition, stop joining with Events because this table is not used in the query.

Fixes thewca#89.
timreyn added a commit to timreyn/statistics that referenced this issue Sep 18, 2022
@timreyn
Sort by RoundType in success streak.
257f438 
Currently the longest_success_streak query does not sort rounds, which leads to nondeterminism when a streak begins / ends during a multi-round competition.

In addition, stop joining with Events because this table is not used in the query.

Fixes thewca#89.
@timreyn timreyn mentioned this issue Sep 18, 2022
Merged
campos20 pushed a commit that referenced this issue Sep 20, 2022
@timreyn
Sort by RoundType in success streak. (#90)
7a0c57c 
Currently the longest_success_streak query does not sort rounds, which leads to nondeterminism when a streak begins / ends during a multi-round competition.

In addition, stop joining with Events because this table is not used in the query.

Fixes #89.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort by RoundType in success streak. timreyn/statistics
1 participant
@timreyn