Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce single-quotes in Rubocop #8419

Open
dunkOnIT opened this issue Oct 13, 2023 · 2 comments
Open

Enforce single-quotes in Rubocop #8419

dunkOnIT opened this issue Oct 13, 2023 · 2 comments
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo

Comments

@dunkOnIT
Copy link
Contributor

If anyone else wants to pick this up, it requires the following in .rubocop.yml:

Style/StringLiterals:
  Enabled: true

And then running rubocop -a to deal with any instances where that rule hasn't been enforced.

I'll try do it later today/on Monday

@dunkOnIT dunkOnIT added the META: good first issue Small/easy change which is a good introduction to working in the WCA repo label Oct 13, 2023
@misaka
Copy link
Contributor

misaka commented Aug 11, 2024

PR created as above, it seems like there isn't enough appetite for this, at the moment at least. Happy to contribute further if this changes.

@dunkOnIT
Copy link
Contributor Author

Yeah unfortunately the risk/reward of trying to go about these changes it too high for the team's capacity at the moment.

If you're interested in contributing on other issues, let me know and I'd be happy to point out some other good first issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo
Projects
Status: No status
Development

No branches or pull requests

2 participants