Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCA Search close icon #8528

Open
danieljames-dj opened this issue Nov 23, 2023 · 2 comments
Open

WCA Search close icon #8528

danieljames-dj opened this issue Nov 23, 2023 · 2 comments
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo TECH: reactJS Requires knowledge of React TYPE: bug Bug reported by a stakeholder

Comments

@danieljames-dj
Copy link
Member

In WcaSearch.jsx, if we select an option, the right side icon is supposed to clear the selection. The icon shown is search icon, and if we click it, it will clear the selection.

Screenshot 2023-11-23 at 21 59 09

If the action of the icon is 'clear', then we need to change the icon to some 'clear' icon.

@dunkOnIT dunkOnIT added TYPE: bug Bug reported by a stakeholder META: good first issue Small/easy change which is a good introduction to working in the WCA repo TECH: reactJS Requires knowledge of React labels Dec 2, 2023
@rafalnawojczyk
Copy link

I would like to contribute on this issue, but I will need further info. Upon testing, this component is probably working fine for now.

When there is any data written into search bar - this Search Icon works as a toggle to show/hide the results dropdown.

What would be the best from UX perspective - when dropdown is extended - this search button should be replaced with "collapse" Icon. If we will try to add "clear' function - we could show it right besides collapse

@danieljames-dj
Copy link
Member Author

Hi @rafalnawojczyk I'm extremely sorry for late reply.

Are you sure that it is currently working as toggle to show or hide dropdown? I think it's not. Currently when I click the search icon, the data is getting cleared which is expected behavior I guess. But the icon shouldn't be 'search' icon, instead it should be some 'clear' icon so that users will know that it will get cleared when that button is clicked.

Thanks for your interest in contributing to this, please let us know if you face any issues while working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo TECH: reactJS Requires knowledge of React TYPE: bug Bug reported by a stakeholder
Projects
Status: No status
Development

No branches or pull requests

3 participants