Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmed_by and results_submitted_by columns in the Competitions table #8641

Open
Baguettely opened this issue Dec 22, 2023 · 1 comment

Comments

@Baguettely
Copy link

Presently, the database stores the WCAT/WRT member who announces a competition / posts the results for a competition, but not the Delegate who submitted them. This means that when WCAT and WRT do background checks, we have to spend a while trawling our emails to find which competitions the Delegate did, rather than being able to run a simple query to find this out.

To solve this, we can add a column to the competitions table called "confirmed_by" which has the user id of the Delegate that confirms the competitions and "results_submitted_by" with the user id of the Delegate that submits the results to WRT (in line with the existing naming systems.) For the confirmed_by field, the Delegate's name and timestamp of confirmation (which is already stored) could then also be displayed at the top of the admin view of the competition page alongside the WCAT member who announces it, and similarly the details of the results submission could be stored within the admin results panel on the competition page.

WRT agreed that there is no need to backfill this information for submissions prior to the introduction of such a change.

Thanks!

@danieljames-dj
Copy link
Member

Hi @Baguettely, I came up with another Tickets model (#8597) after our WRT meeting. It's fine to have the two columns in Competitions table, but the Competitions table is having too much columns already and might not be good for us in long term. If the 'tickets' design gets approved, then we can have confirmed_by and results_submitted_by columns (and other related columns like results_posted_by) to tables like ticket_competition_submission and ticket_result_submission.

Also tickets implementation (if approved) will probably take time, so adding the columns to Competition table temporarily should be fine I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants