Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove avatar when deleting an account/moving WCA ID instead of serving an error to the user #8707

Open
dunkOnIT opened this issue Jan 5, 2024 · 1 comment
Open

Remove avatar when deleting an account/moving WCA ID instead of serving an error to the user #8707

dunkOnIT opened this issue Jan 5, 2024 · 1 comment
Labels
META: good second issue More involved than first issue, these help get a deeper understanding of the codebase TECH: ruby Requires knowledge of Ruby TYPE: feature-request Request for additional functionality to be added to the WCA website

Comments

@dunkOnIT
Copy link
Contributor

dunkOnIT commented Jan 5, 2024

Currentyl when trying to transfer a WCA ID or delete an account, the user is informed that they have to first remove the avatar. This is annoying for the informed user and confusing for the uninformed user.

We should instead flash a warning saying the the avatar will be deleted, requesting confirmation.

I think this is better than silently deleting it, as it may not be obvious that deleting the WCA ID (not the user account) would cause the avatar to be removed).
@dunkOnIT dunkOnIT added META: good second issue More involved than first issue, these help get a deeper understanding of the codebase TECH: ruby Requires knowledge of Ruby TYPE: feature-request Request for additional functionality to be added to the WCA website labels Jan 5, 2024
@dunkOnIT
Copy link
Contributor Author

dunkOnIT commented Jan 5, 2024

I don't think this is a first issue as a lot of the avatar handling code look confusing (to me at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
META: good second issue More involved than first issue, these help get a deeper understanding of the codebase TECH: ruby Requires knowledge of Ruby TYPE: feature-request Request for additional functionality to be added to the WCA website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dunkOnIT