Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcode.allowRotation = false; not working. #90

Open
checknique opened this issue Oct 18, 2018 · 5 comments
Open

Barcode.allowRotation = false; not working. #90

checknique opened this issue Oct 18, 2018 · 5 comments

Comments

@checknique
Copy link

Barcode.allowRotation = false; does not work. Tried it on example app.js too.

Using v2.0.3

@m1ga
Copy link
Contributor

m1ga commented Oct 18, 2018

on iOS it is remove and scans in every direction.
For Android I have to check but I think it is not used.

@checknique
Copy link
Author

Why was it removed? I do not want the camera to rotate in my app. How can I achieve this without Barcode.allowRotation?

@m1ga
Copy link
Contributor

m1ga commented Oct 19, 2018

as far as I understood that parameter it was only used for allowing scanning in both directions, not locking the phone. For android you can change it via xml
https://github.com/appcelerator-modules/ti.barcode/pull/56/files#diff-93c9f93788f810ad7ce3265534905e0aL10

@jwogan5
Copy link
Contributor

jwogan5 commented Oct 23, 2018

@checknique

Look at my new PR to prevent the rotation of your scanner.
#92

It will stay in the same orientation as the calling window.

@checknique
Copy link
Author

@jwogan5 Very cool. I'm really excited for this addition. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants