Doesn't seem to work with `...attributes`

[knownasilya]

{{#let (element this.tagName) as |Tag|}}
  <Tag
    {{did-insert this.setupRoot}}
    ...attributes
  ></Tag>
{{/let}}

Seems to just not work. No errors or anything. In this case tagName is a 'span'.
Full example is here knownasilya/ember-shadow-dom@429b881

[knownasilya]

The ...attributes and element modifier are actually not the cause. It seems like it just doesn't work within the octane blueprint (addon in my case).

[knownasilya]

cc @chancancode

[chancancode]

I tried the following in a fresh octane blueprint app (3.10.0-canary+707a938e), and it seems to work:

{{#let (element 'a') as |Tag|}}
  <Tag href='/'>ohai</Tag>
{{/let}}

Output:

<a id="ember176" class="ember-view" href="/">ohai</a>

(The id and ember-view are an artifact of this polypill, the RFC'ed version would not have them.)

[knownasilya]

@chancancode I think the actual issue is the element modifier

<Tag {{did-insert this.setupRoot}}></Tag>

[jonnygreen]

I'm seeing this exact issue with Ember 3.5.

See this code sandbox https://codesandbox.io/s/ember-element-helper-test-35-l5hg6.

Tag with ...attributes does not render.

It's currently affecting ember-animated 0.7.0 (see ember-animation/ember-animated#146)

[ryanto]

Heya!

It looks like the presence of ...attributes with ember-element-helper break when using Ember 3.5.0 - 3.7.1. This commit, which was released in 3.7.2 fixes the issue: emberjs/ember.js@c801853

Here's a minimal reproduction of the issue: https://github.com/ryanto/element-helper-reproduction Bump the ember-source version to 3.7.2 to see the expected behavior.

Let me know if there's any more info I can provide!

[Panman82]

So just to clarify, is this no longer an issue when used with ember 3.7.2+? And whatever fixed it in 3.7.2 cannot be back-ported to earlier ember versions, or handled by this addon itself? (FWIW, I'm shooting for backwards compatibility to 3.4 in another addon.)

[ryanto]

@Panman82 Since the fix was an update to the version of glimmer used by ember-source, that glimmer version update would have to be backported to the older Ember versions iirc.

[Panman82]

@ryanto sure, understandable that it's unlikely that such things would be backported, since we're so far away from 3.7 anyway. Should this addon have compatibility set to 3.7.2+ and this issue closed?? @chancancode ?