Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISR doesn't seem to work #638

Closed
chandragie opened this issue Oct 25, 2024 · 6 comments
Closed

ISR doesn't seem to work #638

chandragie opened this issue Oct 25, 2024 · 6 comments

Comments

@chandragie
Copy link

Description

I noticed that ISR does not work after deploying, I'm on Vercel.

The build logs however says it's active:

image

image

However, once the app is deployed, the changes in Notion never applied. I tried changing the revalidate value but no luck.

@mabdullahabid
Copy link

Same issue here

@mabdullahabid
Copy link

I was thinking maybe we could add a manual revalidate in order to trigger revalidation instead of having to deploy every time.

@chandragie
Copy link
Author

I was thinking maybe we could add a manual revalidate in order to trigger revalidation instead of having to deploy every time.

did you get it working?

@mabdullahabid
Copy link

Yes, I feel like the issue is not with this repo. Its Vercel. I think for some odd reason the revalidate doesn't work on the free plans. It considers ISR pages as SSG and only rebuilds them at build time. When I deployed the same website on my own VPS, it seemed to revalidate correctly.

@chandragie
Copy link
Author

chandragie commented Oct 28, 2024

Yes, I feel like the issue is not with this repo. Its Vercel. I think for some odd reason the revalidate doesn't work on the free plans. It considers ISR pages as SSG and only rebuilds them at build time. When I deployed the same website on my own VPS, it seemed to revalidate correctly.

What? Really? I must have missed the updates. ISR seems supported in free plan in my first Next project in 2022.
On Vercel, I always get the 500 error complaining about sharp packages. Duh

@chandragie
Copy link
Author

@mabdullahabid it's working now.
So, apparently ISR didn't work because of sharp error on Vercel. Fixed it and now everything including ISR works.
Here how I solved the sharp problem: #618 (comment)

Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants