Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Django 1.8 #5

Open
abompard opened this issue Apr 3, 2015 · 2 comments
Open

Incompatible with Django 1.8 #5

abompard opened this issue Apr 3, 2015 · 2 comments

Comments

@abompard
Copy link

abompard commented Apr 3, 2015

Django 1.8 is just out, and fancy_tag is incompatible with it because the location of some imports have changed.
The following patch fixes it:

--- fancy_tag/__init__.py       2015-04-02 13:10:42.000000000 +0200
+++ fancy_tag/__init__.py       2015-04-02 17:27:16.292665976 +0200
@@ -2,8 +2,9 @@
 import re

 from django.conf import settings
-from django.template import Node, Variable, VariableDoesNotExist, generic_tag_compiler
-from django.template import TemplateSyntaxError, ALLOWED_VARIABLE_CHARS
+from django.template import Node, Variable, VariableDoesNotExist
+from django.template import TemplateSyntaxError
+from django.template.base import ALLOWED_VARIABLE_CHARS
 from django.utils.functional import curry

 kwarg_re = re.compile(r'([^\'"]*)=(.*)')
@funkaoshi
Copy link

I'm pretty sure at this point simpletag does everything fancy_tag was designed to do. (It supports kwrags, etc.) @greatestape was the person who maintained this code, but he doesn't work at Trapeze anymore.

@greatestape
Copy link
Contributor

I think I still have access to the repo. I just haven't had time to work on it. If anything I think it might make sense to update the setup.py to require that django be below a certain version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants