Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into enabling mangle-props and mangle-regex terser's options #23635

Open
XhmikosR opened this issue Aug 23, 2017 · 7 comments
Open

Look into enabling mangle-props and mangle-regex terser's options #23635

XhmikosR opened this issue Aug 23, 2017 · 7 comments

Comments

@XhmikosR
Copy link
Member

See #21715

@XhmikosR XhmikosR changed the title Look into enable mange-props and mangle-regex uglifyjs' options Look into enabling mange-props and mangle-regex uglifyjs' options Aug 23, 2017
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 4, 2017

@Johann-S: you want to leave this open or should we close it?

@Johann-S
Copy link
Member

Johann-S commented Oct 4, 2017

Didn't hade time to shim on that issue 😟 but maybe in the futur 😄 so we can let that issue openned

@mdo
Copy link
Member

mdo commented Dec 17, 2018

@XhmikosR Should we close this out if we're moving off Uglify?

@XhmikosR
Copy link
Member Author

terser has the same options, at least for the time being, so this still applies.

@XhmikosR XhmikosR changed the title Look into enabling mange-props and mangle-regex uglifyjs' options Look into enabling mangle-props and mangle-regex uglifyjs' options Feb 19, 2019
@XhmikosR XhmikosR changed the title Look into enabling mangle-props and mangle-regex uglifyjs' options Look into enabling mangle-props and mangle-regex terser's options Feb 19, 2019
@XhmikosR
Copy link
Member Author

XhmikosR commented May 10, 2020

FYI this does save us currently 608 bytes from the gzip bootstrap.min.js file on the current master:

Screenshot_2020-05-10 Build Results BundleWatch

We just need to test the minified build or something, so that we are sure nothing breaks.

EDIT:

We should really try to do this:

Screenshot_2020-11-21 Build Results BundleWatch

@mdo
Copy link
Member

mdo commented Apr 13, 2022

Closing as stale. If you have time to revisit ever @XhmikosR we can re-open, but I know you're swamped, so let's not push it :).

@mdo mdo closed this as completed Apr 13, 2022
@XhmikosR
Copy link
Member Author

I'm going to open this again, because I think the gains are pretty big to ignore.

Our main issue is that we need a way to test the minified files too.

WIP branch: https://github.com/twbs/bootstrap/compare/main-xmr-min-mangle

@XhmikosR XhmikosR reopened this Apr 14, 2022
@XhmikosR XhmikosR added v6 and removed v4 labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants