Chore/object meta data image #7616
Conversation
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
There was a problem hiding this comment.
PR Summary
This pull request adds an 'imageIdentifier' property to the ObjectMetadata decorator, enhancing the metadata structure for object records across the Twenty application.
- Added 'imageIdentifier' field to GraphQL mutations and queries in
/packages/twenty-front/src/modules/object-metadata/graphql/mutations.tsand/packages/twenty-front/src/modules/object-metadata/graphql/queries.ts - Updated ObjectMetadataEntity in
/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.entity.tsto include the new 'imageIdentifier' column - Modified CreateObjectInput and UpdateObjectPayload in
/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/create-object.input.tsand/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/update-object.input.tsto support the new property - Updated integration tests in
/packages/twenty-server/test/objects.integration-spec.tsto validate the new 'imageIdentifier' field
24 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| imageIdentifier: { | ||
| type: 'string', | ||
| }, |
There was a problem hiding this comment.
style: Consider adding a description for the 'imageIdentifier' property
| @Field({ nullable: true }) | ||
| imageIdentifier: string; |
There was a problem hiding this comment.
style: Consider making imageIdentifier optional to match labelIdentifierFieldMetadataId and imageIdentifierFieldMetadataId
| @IsString() | ||
| @IsOptional() | ||
| @Field({ nullable: true }) | ||
| imageIdentifier?: string; |
There was a problem hiding this comment.
style: Add a comment explaining the purpose and usage of imageIdentifier
| @Column({ nullable: true }) | ||
| imageIdentifier?: string | null; |
There was a problem hiding this comment.
style: Consider adding a comment explaining the purpose and usage of imageIdentifier
|
@Aditya-PS-05 thank you! You seem to have conflicts, could you fix them before we review? |
|
Ok, I am trying to fix this as soon as possible. |
|
@Aditya-PS-05 any update on this one? :) |
|
Sorry I'll close this as it's been open for some time. Please feel free to re-open with the first part. Thank you!! |
closes #3710