Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a field update fails, it should not persist anything to workspace migration table #4849

Open
charlesBochet opened this issue Apr 5, 2024 · 0 comments
Assignees

Comments

@charlesBochet
Copy link
Member

Bug Description

A Twenty users tried to update a SELECT enum option labels while also modifying the defaultValue. This led to a bug which is tracked elsewhere. However, this bug has put the whole workspace into a broken state instead of rolling back changes.

We have implemented transaction on the updateOneField resolver but the transaction does not take into account workspaceMigrations creation. It should, so even if we face an error, the workspace stays in a healthy state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants