Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter on composite sub fields that contain arrays #7188

Open
lucasbordeau opened this issue Sep 20, 2024 · 0 comments
Open

Implement filter on composite sub fields that contain arrays #7188

lucasbordeau opened this issue Sep 20, 2024 · 0 comments
Assignees
Labels
prio: med scope: front Issues that are affecting the frontend side only type: design improvement

Comments

@lucasbordeau
Copy link
Contributor

lucasbordeau commented Sep 20, 2024

Scope & Context

Follow-up of #6425

We implemented filtering on composite field types like ADDRESS and LINKS.

The problem is that we still have to implement filtering on their subfields like secondaryLinks or additionalPhones because they need a special treatment, they are like sub-sub-fields.

Current behavior

Currently we can filter on sub field of level 1.

Expected behavior

We want to be able to filter on sub fields that contains arrays, sometimes arrays of objects like additionalPhones which contains an array of PhoneRecord : additionalPhones?: PhoneRecord[] | null;

Technical inputs

See if there's some work on the backend involved ?

We'll also have to handle the filtering for the frontend cache that mirrors the backend filtering for those fields.

@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only type: design improvement prio: med labels Sep 23, 2024
lucasbordeau added a commit that referenced this issue Oct 8, 2024
# This PR

- Fix #6425 

See #7188 because there's some
more work to do.

---------

Co-authored-by: Lucas Bordeau <[email protected]>
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
# This PR

- Fix twentyhq#6425 

See twentyhq#7188 because there's some
more work to do.

---------

Co-authored-by: Lucas Bordeau <[email protected]>
@lucasbordeau lucasbordeau moved this from 🆕 New to 🔖 Planned in Product development ✅ Nov 12, 2024
@lucasbordeau lucasbordeau self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: med scope: front Issues that are affecting the frontend side only type: design improvement
Projects
Status: 🔖 Planned
Development

No branches or pull requests

2 participants