Treat no value view group as normal & enable hide/dnd for no value #8613
+40
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR modifies the handling of 'No Value' groups in the Kanban view to treat them as regular view groups, enabling hide and drag-and-drop functionality that was previously disabled.
- Modified
mapViewGroupsToRecordGroupDefinitions.tsto respect visibility and position settings for 'No Value' groups - Removed special filtering of 'No Value' groups in
ViewGroupsVisibilityDropdownSection.tsxfor consistent group handling - Removed conditional check in
useRecordGroupActions.tsthat prevented hiding 'No Value' groups - Updated group sorting to use position values for all groups including 'No Value'
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| <DraggableItem | ||
| key={viewGroup.id} | ||
| draggableId={viewGroup.id} | ||
| index={viewGroupIndex + 1} |
There was a problem hiding this comment.
logic: index starts at 1 which may cause issues with array indexing in drag and drop handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8591
Summary
We disabled hide/dnd(drag-and-drop) options for
No valueview group intentionally in the first implementation. We want to change it to behave like normal view groups, so enable hide/dnd forNo valueview group as well.Solution
I have removed the code that filters the
No valuegroup out of view groups, soNo valueis stored in the same array as other view groups. I have removed theNo valueflag check forHidebutton on the hamburger menu of the Kanban header. I had to update the code inpackages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.tsbecause it was ignoring the visibility flag of theNo valueview group and set it always to true. Also, it was always putting theNo valuegroup last ignoring the previous position.https://github.com/user-attachments/assets/e135e22e-6e3a-4f94-a898-aafc03bba060