Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL is broken #44

Closed
okainov opened this issue Aug 13, 2024 · 0 comments
Closed

URL is broken #44

okainov opened this issue Aug 13, 2024 · 0 comments

Comments

@okainov
Copy link
Contributor

okainov commented Aug 13, 2024

Before I started looking into code, I didn't even realize it's an issue.

Seems like the code is supposed to send the link to memo. However it's not:
image

When I debug it, then it seems that the raw text looks like this:

 Content saved with [memos/20](dns:mynotes.mydomain.com:1234/m/P8uDDkAPXCKEhPTFo5NYjs)

Obviously, dns:... stuff is not a valid URL, so Telegram cannot parse it. Please use actual real URL there.
okainov added a commit to okainov/telegram-integration that referenced this issue Aug 13, 2024
@okainov
fix: transform DNS to URL
7de42a5 
Add some sane default transformation to the
server address.

Fixes: usememos#44
@okainov okainov mentioned this issue Aug 13, 2024
Closed
okainov added a commit to okainov/telegram-integration that referenced this issue Aug 13, 2024
@okainov
fix: transform DNS to URL
47c5f7a 
Add some sane default transformation to the
server address.

Fixes: usememos#44
okainov added a commit to okainov/telegram-integration that referenced this issue Aug 13, 2024
@okainov
fix: transform DNS to URL
6d7e5cd 
Add some sane default transformation to the
server address.

Fixes: usememos#44
okainov added a commit to okainov/telegram-integration that referenced this issue Aug 13, 2024
@okainov
fix: transform DNS to URL
9fb248f 
Add some sane default transformation to the
server address.

Fixes: usememos#44
@wolfsilver wolfsilver mentioned this issue Aug 26, 2024
Merged
@boojack boojack closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: transform DNS to URL okainov/telegram-integration
2 participants
@okainov @boojack