Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memos will create separate memos for each photo in a Telegram message rather than multiple photos in one memo #49

Closed
dwong33 opened this issue Aug 23, 2024 · 4 comments · Fixed by #53
Assignees
Labels
enhancement New feature or request

Comments

@dwong33
Copy link

dwong33 commented Aug 23, 2024

The content of this bug is the same as this one, but that issue is closed:

#23

But the bug is not being addressed as of v0.22.4.

Previously, we can include multiple photos in a memos by using Telegram bot. But currently, if we attempt to create a memos with more than one photo, memos will create each photo a memo, which is not the expected outcome.

@boojack boojack added the enhancement New feature or request label Aug 26, 2024
@boojack boojack self-assigned this Aug 26, 2024
@okainov
Copy link
Contributor

okainov commented Aug 27, 2024

This sounds as trivial as replacing accessing last picture in if to for-loop here: https://github.com/usememos/telegram-integration/blob/main/memogram.go#L174

@okainov
Copy link
Contributor

okainov commented Aug 28, 2024

Just looking at it, it still looks exactly what we need :) Each PhotoSize has FileID (which we use), so just iterate over it...

@boojack
Copy link
Member

boojack commented Aug 29, 2024

@okainov The problem now is that it will be saved as multiple memos instead of just one memo with the last image in it.

And the photosize is all available size of the image with same file id. Not what you thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants