From e574e2aacd49ed786b69e2b5f65be0abc0c60db9 Mon Sep 17 00:00:00 2001
From: IceCodeNew <32576256+IceCodeNew@users.noreply.github.com>
Date: Fri, 25 Sep 2020 00:22:34 +0800
Subject: [PATCH] switch from `command` to `type`; put `dnf` ahead of `yum`;
 assume yes

0. command -v could return an alias while type -P will force a PATH search
1. There are distribution that has aliases for `apt` or `yum` while its prefer package manager is not `apt` nor ``yum
2. Assume yes for the call we made to all kind of package managers
---
 install-release.sh | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/install-release.sh b/install-release.sh
index 4c6f680..4aec23e 100644
--- a/install-release.sh
+++ b/install-release.sh
@@ -97,21 +97,20 @@ identify_the_operating_system_and_architecture() {
       echo "error: Only Linux distributions using systemd are supported."
       exit 1
     fi
-    if [[ "$(command -v apt)" ]]; then
-      PACKAGE_MANAGEMENT_INSTALL='apt install'
-      PACKAGE_MANAGEMENT_REMOVE='apt remove'
-    elif [[ "$(command -v yum)" ]]; then
-      PACKAGE_MANAGEMENT_INSTALL='yum install'
-      PACKAGE_MANAGEMENT_REMOVE='yum remove'
-      if [[ "$(command -v dnf)" ]]; then
-        PACKAGE_MANAGEMENT_INSTALL='dnf install'
+    if [[ "$(type -P apt)" ]]; then
+      PACKAGE_MANAGEMENT_INSTALL='apt install -y --no-install-recommends'
+      PACKAGE_MANAGEMENT_REMOVE='apt purge'
+    elif [[ "$(type -P dnf)" ]]; then
+        PACKAGE_MANAGEMENT_INSTALL='dnf install -y'
         PACKAGE_MANAGEMENT_REMOVE='dnf remove'
-      fi
-    elif [[ "$(command -v zypper)" ]]; then
-      PACKAGE_MANAGEMENT_INSTALL='zypper install'
+    elif [[ "$(type -P yum)" ]]; then
+      PACKAGE_MANAGEMENT_INSTALL='yum install -y'
+      PACKAGE_MANAGEMENT_REMOVE='yum remove'
+    elif [[ "$(type -P zypper)" ]]; then
+      PACKAGE_MANAGEMENT_INSTALL='zypper install -y'
       PACKAGE_MANAGEMENT_REMOVE='zypper remove'
-    elif [[ "$(command -v pacman)" ]]; then
-      PACKAGE_MANAGEMENT_INSTALL='pacman -S'
+    elif [[ "$(type -P pacman)" ]]; then
+      PACKAGE_MANAGEMENT_INSTALL='pacman -S --noconfirm'
       PACKAGE_MANAGEMENT_REMOVE='pacman -R'
     else
       echo "error: The script does not support the package manager in this operating system."