Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoopSpawning reports that it did not transform anything if verifyFunction() fails. #22

Open
VictorYing opened this issue Oct 22, 2017 · 0 comments

Comments

@VictorYing
Copy link
Contributor

VictorYing commented Oct 22, 2017

Is there a design reason that LoopSpawning, at several points, checks the return value of verifyFunction() and, if the verification fails, it merely returns false indicating it did not transform anything, despite the fact that, at those locations in the code, some transformations have indeed been attempted? Was there some point during development where letting bad transformed code continue through the compilation pipeline made sense? I have sometimes locally changed the verifyFunction() checks into asserts which was useful when I was debugging an issue,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant